[Ruby][faraday] fix download_file #7842
Merged
+22
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsuwatch
commented
Oct 30, 2020
| def download_file(request) | ||
| tempfile = nil | ||
| encoding = nil | ||
| request.headers do |response| |
There was a problem hiding this comment.
Does not process this block.
wing328
reviewed
Oct 30, 2020
modules/openapi-generator/src/main/resources/ruby-client/api_client_faraday_partial.mustache
Show resolved
Hide resolved
tsuwatch
commented
Oct 30, 2020
| @@ -232,7 +203,8 @@ def deserialize(response, return_type) | |||
| # handle file downloading - return the File instance processed in request callbacks | |||
| # note that response body is empty when the file is written in chunks in request on_body callback | |||
| if return_type == 'File' | |||
| @tempfile.write(@stream) | |||
| @tempfile = Tempfile.open('download-', @config.temp_folder_path, encoding: body.encoding) | |||
| @tempfile.write(@stream.join.force_encoding(body.encoding)) | |||
There was a problem hiding this comment.
Need to force_encoding
|
CI failure not related to this PR. |
|
Thanks |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #7734
download_filedoesn't work.PR checklist
./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.mastercc @cliffano (2017/07) @zlx (2017/09) @autopp (2019/02)