-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ruby][faraday] fix response streaming #7734
Conversation
# handle streaming Responses | ||
request.options.on_data = Proc.new do |chunk, overall_received_bytes| | ||
# puts "Received #{overall_received_bytes} characters" | ||
tempfile.write(chunk) | ||
@stream << chunk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you use a block, the file will be closed automatically.
Can this be used?
https://docs.ruby-lang.org/en/2.0.0/Net/HTTP.html#class-Net::HTTP-label-Streaming+Response+Bodies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be. Previously I got IO error when using tempfile.write(chunk)
.
Can you test your suggested fix locally and if it works, can you please file a PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, I got it.
Thank you very much for fixing my issue. |
To fix #7708
Tested locally to confirm the fix.
PR checklist
./bin/generate-samples.sh
to update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*
. For Windows users, please run the script in Git BASH.master
cc @cliffano (2017/07) @zlx (2017/09) @autopp (2019/02)