Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ocaml] Fix missing space on models #7742

Merged
merged 1 commit into from
Oct 20, 2020

Conversation

Zomzog
Copy link
Contributor

@Zomzog Zomzog commented Oct 18, 2020

It's not covered by generated tests. Maybe I can add one?

fix #7738

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

ping @cgensoul

@wing328
Copy link
Member

wing328 commented Oct 20, 2020

It's not covered by generated tests. Maybe I can add one?

We can use https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/test/resources/3_0/petstore-with-fake-endpoints-models-for-testing.yaml instead which covers a lot more edge cases but the OCaml client generator may not be ready to handle all these.

@wing328 wing328 added this to the 5.0.0 milestone Oct 20, 2020
@wing328 wing328 merged commit b1ea1ec into OpenAPITools:master Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] spaces missing from type hints in generated ocaml code
2 participants