Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] spaces missing from type hints in generated ocaml code #7738

Closed
bobpoekert opened this issue Oct 18, 2020 · 3 comments · Fixed by #7742
Closed

[BUG] spaces missing from type hints in generated ocaml code #7738

bobpoekert opened this issue Oct 18, 2020 · 3 comments · Fixed by #7742

Comments

@bobpoekert
Copy link

bobpoekert commented Oct 18, 2020

Description

Running the ocaml code generator generates code that fails to build because spaces have been removed from type declarations that should have space. Eg: string option becomes stringoption

openapi-generator version

Both git master and 4.3.1 release

OpenAPI declaration file content or url

https://github.com/stripe/openapi/blob/master/openapi/spec3.yaml, though I'm sure a simpler spec would also fail

Zomzog added a commit to Zomzog/openapi-generator that referenced this issue Oct 18, 2020
@wing328
Copy link
Member

wing328 commented Oct 19, 2020

Thanks @Zomzog for filing a fix (#7742)

@bobpoekert can you please also review the fix when you've time?

@wing328 wing328 added this to the 5.0.0 milestone Oct 19, 2020
@cgensoul
Copy link
Contributor

The fix is fine and legit, you can merge it @wing328. Please not that it is not enough to generate compilable code from the https://github.com/stripe/openapi/blob/master/openapi/spec3.yaml though but it still one step closer.

@wing328
Copy link
Member

wing328 commented Oct 20, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants