Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ruby] Replace DateTime with Time #7656

Merged
merged 3 commits into from
Oct 21, 2020
Merged

[Ruby] Replace DateTime with Time #7656

merged 3 commits into from
Oct 21, 2020

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Oct 12, 2020

As per the conversation in #7648

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

cc @cliffano (2017/07) @zlx (2017/09) @autopp (2019/02)

@jfeltesse-mdsol
Copy link
Contributor

at a glance, you need to add require 'time' at the top of the ruby templates.

@wing328
Copy link
Member Author

wing328 commented Oct 12, 2020

@jfeltesse-mdsol yup, thanks for the review. The CI also caught the issue.

Fixed via baf92ab

@wing328 wing328 marked this pull request as ready for review October 12, 2020 11:41
@wing328 wing328 merged commit ec74b06 into master Oct 21, 2020
@wing328 wing328 deleted the ruby-datetime branch October 21, 2020 06:14
@wing328 wing328 mentioned this pull request Dec 4, 2020
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants