Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ruby] fix DateTime default value #7648

Merged
merged 5 commits into from
Oct 12, 2020
Merged

[Ruby] fix DateTime default value #7648

merged 5 commits into from
Oct 12, 2020

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Oct 11, 2020

To fix exception when DateTime property has a default value.

The updated code looks like the following:

      if attributes.key?(:'date')
        self.date = attributes[:'date']
      else
        self.date = Date.parse("2010-02-01")
      end

      if attributes.key?(:'date_time')
        self.date_time = attributes[:'date_time']
      else
        self.date_time = DateTime.parse("2010-02-01T09:20:10.111110Z[UTC]")
      end

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

cc @cliffano (2017/07) @zlx (2017/09) @autopp (2019/02)

@wing328 wing328 added this to the 5.0.0 milestone Oct 11, 2020
@wing328 wing328 mentioned this pull request Oct 11, 2020
5 tasks
@jfeltesse-mdsol
Copy link
Contributor

I guess it'll be for another PR but FYI DateTime in ruby is discouraged, see Matz' answer at https://bugs.ruby-lang.org/issues/15712#note-4

Also I'm not sure if the timestamp example is the way it's done in Java but the Z already denotes the UTC timezone so it strikes me as odd to have [UTC]. Maybe use a different timezone to ensure not only the default path that UTC is works?

@wing328
Copy link
Member Author

wing328 commented Oct 12, 2020

Thanks for the review and sharing more. We'll need to replace DateTime with Time in another PR instead as this one aims to resolve the exception thrown due to datetime default value, which is a blocker for your work.

@wing328 wing328 merged commit 874b4a6 into master Oct 12, 2020
@wing328 wing328 deleted the ruby-fix-date branch October 12, 2020 03:49
@wing328 wing328 mentioned this pull request Oct 12, 2020
6 tasks
@wing328
Copy link
Member Author

wing328 commented Oct 12, 2020

Filed #7656 to replace DateTime with Time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants