Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement useAbstractionForFiles for webclient library #7567

Merged
merged 2 commits into from
Jan 25, 2021

Conversation

iyzana
Copy link
Contributor

@iyzana iyzana commented Oct 1, 2020

This pull-request extends #6912 by providing an implementation of the new useAbstractionForFiles flag for the webclient library.
The original issue was #6715 . I left a comment on that ticket mentioning that the functionality would be nice to have for the webclient as well.
In this PR I mostly just adapted the changes that were necessary for the resttemplate to work for the webclient.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @bkabrda

@iyzana iyzana force-pushed the webclient-abstraction-for-files branch 2 times, most recently from 1f79c5e to 276f95d Compare October 8, 2020 09:53
@iyzana
Copy link
Contributor Author

iyzana commented Oct 8, 2020

I'm not sure why the circleci build is still failing

@wing328
Copy link
Member

wing328 commented Jan 7, 2021

@iyzana can you please resolve the merge conflicts when you've time? We'll look into the CI issue later if it's still failing.

@iyzana iyzana force-pushed the webclient-abstraction-for-files branch from 276f95d to 267877c Compare January 8, 2021 18:38
@iyzana
Copy link
Contributor Author

iyzana commented Jan 8, 2021

rebased

@wing328
Copy link
Member

wing328 commented Jan 25, 2021

Pushed f9a8614 to fix CI failures. Let's see how that goes.

@wing328 wing328 merged commit ecf9056 into OpenAPITools:master Jan 25, 2021
@wing328 wing328 added this to the 5.0.1 milestone Jan 25, 2021
@MosheElisha
Copy link
Contributor

@noako when you update the java.md docs as part of #8549 , please consider mentioning that the useAbstractionForFiles is also supported for webclient library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants