Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java][RestTemplate] Use abstraction for files #6912

Merged

Conversation

MosheElisha
Copy link
Contributor

@MosheElisha MosheElisha commented Jul 12, 2020

  1. Add a new "useAbstractionForFiles" config option that uses abstract objects instead of files where files are needed. With this option, the user will be able to use byte array or input stream instead of java.io.File. The new config option is currently supported only by the resttemplate library.

  2. Fix the dir path mentioned in the pull request template.

To close #6715

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

…llow flexible options in generated client when a file is needed (OpenAPITools#6715)
…llow flexible options in generated client when a file is needed (OpenAPITools#6715)
@MosheElisha MosheElisha mentioned this pull request Jul 12, 2020
5 tasks
@MosheElisha
Copy link
Contributor Author

Adding the Java technical committee as requested - @wing328 @bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @bkabrda. Please review.

@MosheElisha
Copy link
Contributor Author

A kind reminder. Would appreciate a review @wing328 @bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @bkabrda.

Thanks.

@wing328 wing328 added this to the 5.0.0 milestone Jul 20, 2020
@wing328 wing328 changed the title Use abstraction for files (#6715) Use abstraction for files Jul 20, 2020
…va/RestTemplate to allow flexible options in generated client when a file is needed.
@wing328 wing328 changed the title Use abstraction for files [Java][RestTemplate] Use abstraction for files Jul 20, 2020
@wing328
Copy link
Member

wing328 commented Jul 20, 2020

CircleCI failure not related to this change.

Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and the result is good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Java/RestTemplate - Allow flexible options in generated client when a file is needed
2 participants