[jaxrs-spec] setup test for samples, repair import and dependency #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs-spec-interface-response" should be tested
add jackson annotation dependency
…nterface-response
wing328
reviewed
Aug 7, 2018
| <modules> | ||
| <module>samples/server/petstore/jaxrs-spec-interface-response</module> | ||
| </modules> | ||
| </profile> |
There was a problem hiding this comment.
@fujigon Thanks for including jaxrs-spec samples in the Travis CI.
We'll move these tests to CircleCI instead as we've setup both JDK7 and JDK8 to test the change in parallel.
@fujigon I think it's ok. Thanks for elaborating on the change to make the review easier 👍 |
wing328
approved these changes
Aug 7, 2018
4 tasks
wing328
changed the title
wing328
changed the title
wing328
changed the title
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
…OpenAPITools#755) * sample server projects "jaxrs-spec", "jaxrs-spec-interface", and "jaxrs-spec-interface-response" should be tested * update jax-rs api to 2.1, in which @patch annotation is available add jackson annotation dependency * add joda-time to dependency * modify mustache template to add @JsonCreate, @JsonValue import * fix return type of enum value() method * add InputStream import * Attachment class is in apache cxf. spec should not depend on it * re-generate sample jaxrs-spec, jaxrs-spec-interface, and jaxrs-spec-interface-response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,4.0.x. Default:master.@bbdouglas @JFCote @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger
@wing328
Description of the PR
This patch fixes #726
Changes
jaxrs-spec,jaxrs-spec-interfaceandjaxrs-spec-interface-responseare testedDisscussion
multipart/form-data related
f8691ed
I googled multipart/form-data related annotation for pure jax-rs, but I came to the conclusion that there'is no suitable one. (So, jersey, apache-cxf and rest-easy define their own annotation to support multipart/form-data).
So, in
jaxrs-spec, I deleted theAttachment fileDetailfield from the template.Is this fix OK?
Note
Last commit dc5b9e0 includes only sample re-generation by
./bin/jaxrs-spec-petstore-server*.