-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jaxrs-spec] setup test for samples, repair import and dependency #755
[jaxrs-spec] setup test for samples, repair import and dependency #755
Conversation
…rs-spec-interface-response" should be tested
add jackson annotation dependency
…nterface-response
<modules> | ||
<module>samples/server/petstore/jaxrs-spec-interface-response</module> | ||
</modules> | ||
</profile> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fujigon Thanks for including jaxrs-spec samples in the Travis CI.
We'll move these tests to CircleCI instead as we've setup both JDK7 and JDK8 to test the change in parallel.
@fujigon I think it's ok. Thanks for elaborating on the change to make the review easier 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and the result is good
…OpenAPITools#755) * sample server projects "jaxrs-spec", "jaxrs-spec-interface", and "jaxrs-spec-interface-response" should be tested * update jax-rs api to 2.1, in which @patch annotation is available add jackson annotation dependency * add joda-time to dependency * modify mustache template to add @JsonCreate, @JsonValue import * fix return type of enum value() method * add InputStream import * Attachment class is in apache cxf. spec should not depend on it * re-generate sample jaxrs-spec, jaxrs-spec-interface, and jaxrs-spec-interface-response
PR checklist
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
and./bin/security/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
.master
,4.0.x
. Default:master
.@bbdouglas @JFCote @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger
@wing328
Description of the PR
This patch fixes #726
Changes
jaxrs-spec
,jaxrs-spec-interface
andjaxrs-spec-interface-response
are testedDisscussion
multipart/form-data related
f8691ed
I googled multipart/form-data related annotation for pure jax-rs, but I came to the conclusion that there'is no suitable one. (So, jersey, apache-cxf and rest-easy define their own annotation to support multipart/form-data).
So, in
jaxrs-spec
, I deleted theAttachment fileDetail
field from the template.Is this fix OK?
Note
Last commit dc5b9e0 includes only sample re-generation by
./bin/jaxrs-spec-petstore-server*
.