Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jaxrs-spec*] samples/server/petstore/jaxrs-spec* are not compilable #726

Closed
fujigon opened this issue Aug 3, 2018 · 1 comment · Fixed by #755
Closed

[jaxrs-spec*] samples/server/petstore/jaxrs-spec* are not compilable #726

fujigon opened this issue Aug 3, 2018 · 1 comment · Fixed by #755

Comments

@fujigon
Copy link
Contributor

fujigon commented Aug 3, 2018

Description

Sample maven projects of jaxrs-spec, jaxrs-spec-interface, jaxrs-spec-interface-response are not compilable.

openapi-generator version

master branch (a258cf3)

OpenAPI declaration file content or url

master branch (a258cf3)

Command line used for generation

I used the example on the master branch.

Steps to reproduce

environment

  • Windows 10
  • git bash
  • Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-18T03:33:14+09:00)
  • Java(TM) SE Runtime Environment (build 1.8.0_161-b12)

patch
Changed samples/server/petstore/jaxrs-spec/jaxrs-spec/pom.xml to add the generated sources into its compilation. (fujigon@69d51fd#diff-4b89ff23dee396d29fbaa7412736b5bf)

And I kick

cd samples/server/petstore/jaxrs-spec
mvn test

then, I get compile error https://gist.github.com/fujigon/f5c8e591548e0e8ec30bc019be73ad9d.

Related issues/PRs

N/A

Suggest a fix/enhancement

Currently, the whole project is buildable because it doesn't add sub-projects jaxrs-spec, jaxrs-spec-interface, and jaxrs-spec-interface-response into the root project.

I think these sub-projects should be integrated to the root project with profile as the other sample projects are, so that CI confirms that the sub-projects are buildable. (like fujigon@69d51fd#diff-600376dffeb79835ede4a0b285078036)
And then, we need to modify the jaxrs-spec language mustache template so that the generated code is compilable.

@wing328
Copy link
Member

wing328 commented Aug 5, 2018

@fujigon thanks for reporting the issue. You're right and please file a PR with the patch to fix the pom.xml to start with. We'll then work together to fix the remaining issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants