[Rust] Ignore additional properties #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wing328
reviewed
Jul 28, 2018
| // them recognised correctly. | ||
| cm.isAlias = false; | ||
| cm.dataType = typeMapping.get(cm.dataType); | ||
| if (cm.dataType == "map") { |
There was a problem hiding this comment.
@bjgill should this be "map".equals(cm.dataType) instead?
There was a problem hiding this comment.
Good point - I'll be consistent with the equivalent 5 lines previously, though - cm.dataType.equals("map")
added 2 commits
July 30, 2018 10:18
rust-server doen't yet support them, and they cause quite a bit of havoc at the moment (ending up as the `HashMap` type).
|
Not sure why travis failed. Doesn't seem to be anything Rust-related, though. Do you have the ability to retry the job? |
|
@bjgill Restarted the job. Let's see how it goes |
|
That passed, thanks. |
wing328
changed the title
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
* Ignore additionalProperties rust-server doen't yet support them, and they cause quite a bit of havoc at the moment (ending up as the `HashMap` type). * Use .equals() rather than `==`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,4.0.x. Default:master.Description of the PR
This is a workaround for #318. In swagger-codegen, we did not support
additionalPropertiesand so ignored them.In openapi-generator, we now get back a type (
map), where we got back a null previously.postProcessModelsdoesn't have enough context to work out what sort of map is required (we don't know the types of theadditionalProperties).Thus, this workaround detects this specific failure case and fiddles with the
dataTypeto getadditionalPropertiesignored again. This will allow us to generate from specs containingadditionalPropertiesand have the resultant crates compile.I've added in a warning to users to let them know what's happening.
I'm building on top of #658 to allow us to add a test to ensure that we don't regress this in future.