Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rust-server] add support for multiple samples #658

Merged
merged 3 commits into from
Jul 30, 2018
Merged

[rust-server] add support for multiple samples #658

merged 3 commits into from
Jul 30, 2018

Conversation

bjgill
Copy link
Contributor

@bjgill bjgill commented Jul 26, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language. @frol @farcaller

Description of the PR

Though we only have the one as yet. This will make it easier to move rust-server back on to the main test spec, whilst preserving the ability to have rust-specific test specs. I'm currently using this to regression test openapi-generator against a variety of specs previously used for swagger-codegen.

Benjamin Gill added 3 commits July 27, 2018 12:32
Though we only have the one as yet. This will make it easier to move rust-server back on to the main test spec, whilst preserving the ability to have rust-specific test specs.
So that there is nothing else in the folder where they live so that the workspace definition in the root Cargo.toml can be simple.
@bjgill bjgill changed the title Multiple rust samples [rust-server] add support for multiple samples Jul 27, 2018
@bjgill bjgill mentioned this pull request Jul 27, 2018
4 tasks
@wing328 wing328 added this to the 3.2.0 milestone Jul 30, 2018
@wing328 wing328 merged commit cb9a734 into OpenAPITools:master Jul 30, 2018
@wing328
Copy link
Member

wing328 commented Jul 30, 2018

@bjgill bjgill deleted the multiple-rust-samples branch July 30, 2018 09:12
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
* Add support for multiple rust-server samples

Though we only have the one as yet. This will make it easier to move rust-server back on to the main test spec, whilst preserving the ability to have rust-specific test specs.

* Rust samples need unique names

* Move samples to a dedicated directory

So that there is nothing else in the folder where they live so that the workspace definition in the root Cargo.toml can be simple.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants