Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Shippable CI specific pom file #319

Merged
merged 1 commit into from
Jun 15, 2018
Merged

Remove Shippable CI specific pom file #319

merged 1 commit into from
Jun 15, 2018

Conversation

jmini
Copy link
Member

@jmini jmini commented Jun 14, 2018

As discussed in #305, this PR is about removing the different pom files used for CI.

@jmini jmini added Enhancement: CI/Test WIP Work in Progress labels Jun 14, 2018
@jmini
Copy link
Member Author

jmini commented Jun 14, 2018

For Shippable:

I have compared /pom and /CI/pom.xml.shippable

  • jmustache version
    • /pom.xml defines jmustache-version == 1.14,
    • /CI/pom.xml.shippable defines jmustache-version == 1.12
  • /pom.xml has some additional configurations (like distributionManagement section) and a release profile to perform a release
  • maven-checkstyle-plugin and formatter-maven-plugin are commented /pom.xml
  • the profile name used to run tests for some samples are not the same:
  • some paths are different

My take is that the small differences do not justify to maintain two version of the pom file.
With cfae3f7 I have removed /CI/pom.xml.shippable and of course I have merged the samples.shippable profile section into /pom.xml

@jmini jmini removed the WIP Work in Progress label Jun 15, 2018
@wing328 wing328 added this to the 3.0.2 milestone Jun 15, 2018
@jmini jmini changed the title [WIP] Remove CI specific pom files Remove Shippable CI specific pom file Jun 15, 2018
@jmini jmini merged commit 5630746 into master Jun 15, 2018
@jmini jmini deleted the remove_ci_poms branch July 5, 2018 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants