Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: prevent ELM to run on Shippable #305

Merged
merged 1 commit into from
Jun 13, 2018

Conversation

jmini
Copy link
Member

@jmini jmini commented Jun 13, 2018

Reported by @wing328 on Gitter:

I wonder if you can take a look at https://app.shippable.com/github/OpenAPITools/openapi-generator/runs/772/1/console
the error is related to elm
but there's no elm in CI/pom.xml.shippable...

Error:

Compiling src/Main.elm
./elm-compile-test: line 7: elm: command not found
[ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.2.1:exec (bundle-test) on project ElmClientTests: Command execution failed.: Process exited with an error: 127 (Exit value: 127) -> [Help 1]

This is probably a side effect of the change I have made in #280 to solve this error:

[ERROR] [FATAL] Non-resolvable parent POM for org.openapitools:openapi-generator-cli:[unknown-version]: Could not find artifact org.openapitools:openapi-generator-project:pom:3.0.1 in sonatype-snapshots (https://oss.sonatype.org/content/repositories/snapshots) and 'parent.relativePath' points at wrong local POM @ line 3, column 11

Change made in #280:

I needed to call the main POM: /pom.xml from CI/pom.xml.shippable in order to build the missing module.

It probably introduces the observed side-effect in https://app.shippable.com/github/OpenAPITools/openapi-generator/runs/772/1/console


This PR changes the profile name for Shippable from samples to samples.shippable.

Changed files:

  • CI/pom.xml.shippable : new definition
  • shippable.yaml : activate the correct profile with -P

@jmini
Copy link
Member Author

jmini commented Jun 13, 2018

@wing328 : do you know why there are several pom.xml? Maybe we could merge back /CI/pom.xml.shippable and /pom.xml now that I have introduced different profile name for the different CI servers...

This would help the maintenance of all those poms...

(we can do this in a separated PR)

@wing328 wing328 added this to the 3.0.2 milestone Jun 13, 2018
@jmini jmini merged commit f964873 into OpenAPITools:master Jun 13, 2018
@jmini jmini deleted the fix_shippable_ci branch June 13, 2018 13:05
@wing328
Copy link
Member

wing328 commented Jun 13, 2018

@jmini please feel free to consolidate multiple pom.xml into one for different CIs to test/build (assuming there's no difference when CI containers run the tests)

@jmini
Copy link
Member Author

jmini commented Jun 14, 2018

feel free to consolidate multiple pom.xml into one for different CIs to test/build (assuming there's no difference when CI containers run the tests)

Started in #319.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants