Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++][Qt5]Map number to double since float is also parsed as double in Qt5 #3046

Merged
merged 1 commit into from
May 31, 2019

Conversation

etherealjoy
Copy link
Contributor

@etherealjoy etherealjoy commented May 31, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Fixes #3037

Changes:

  • Map float and double to double since QJsonObject always treat float and double as double

cc: @stkrwork @MartinDelille @ravinikam @wing328

@etherealjoy etherealjoy changed the title [C++][Qt5]Map number to double time since float is also parsed as double in Qt5 [C++][Qt5]Map number to double since float is also parsed as double in Qt5 May 31, 2019
Copy link
Contributor

@stkrwork stkrwork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no samples regenerated?

@etherealjoy
Copy link
Contributor Author

No number types in the samples :|

@stkrwork
Copy link
Contributor

ci failure not because of pr

@stkrwork stkrwork merged commit 7ecc991 into OpenAPITools:master May 31, 2019
@etherealjoy etherealjoy added this to the 4.0.2 milestone May 31, 2019
jimschubert added a commit that referenced this pull request Jun 2, 2019
* master:
  Update version to 4.0.2-SNAPSHOT (#3047)
  Map number to double time since float is also parsed as double in Qt5 C++ (#3046)
jimschubert added a commit to jimschubert/openapi-generator that referenced this pull request Jun 5, 2019
* 4.1.x: (56 commits)
  sync master
  Update compatibility table
  Ruby client: escape path parameters (OpenAPITools#3039)
  [gradle plugin] Release 4.0.1 fixes (OpenAPITools#3051)
  Update version to 4.0.2-SNAPSHOT (OpenAPITools#3047)
  Map number to double time since float is also parsed as double in Qt5 C++ (OpenAPITools#3046)
  Prepare 4.0.1 release (OpenAPITools#3041)
  [gradle] Reworking publishing pipeline (OpenAPITools#2886)
  [typescript-fetch] Fix uploading files (OpenAPITools#2900)
  Resolves OpenAPITools#2962 - Add properties config to Maven parameters (OpenAPITools#2963)
  fix(golang): Check error of xml Encode (OpenAPITools#3027)
  [C++][Restbed] Add handler callback methods (OpenAPITools#2911)
  Remove null checks for C# value types (OpenAPITools#2933)
  [python-server] Support python 3.7 for all server-generators (OpenAPITools#2884)
  Use golang's provided method names (gin) (OpenAPITools#2983)
  [python] Adding constructor parameters to Configuration and improving documentation (OpenAPITools#3002)
  Add new option to maven plugin's readme (OpenAPITools#3025)
  Engine param in maven plugin. (OpenAPITools#2881)
  Added support for patterns on model properties (OpenAPITools#2948)
  [csharp] Make API response headers dictionary case insensitive (OpenAPITools#2998)
  ...
@etherealjoy etherealjoy deleted the fix_number_type branch September 16, 2019 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[C++][QT5]Basic header file missing for cpp-qt5-client generator
2 participants