Ruby client: escape path parameters #3039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ccouzens Thank you for your PR! I'll review it. |
autopp
requested changes
Jun 2, 2019
There was a problem hiding this comment.
@ccouzens The changes are LGTM 👍
But CircleCI reported that samples/openapi3/client/petstore/ruby was not updated.
Would you also run bin/openapi3/ruby-client-petstore.sh?
(The failure of appveyor seems to have nothing to do with this PR)
Path parameters should be escaped when encoded into the path.
In the path '/pet/{petId}' let's pretend petId is a string instead of a
number.
If the user uses "Bobby" as the petId then they correctly get the path
'/pet/Bobby'.
But if they put 'Bobby/Tables' as the petId then they used to get the
path '/pet/Bobby/Tables' which will be interpreted by the server as a
different route.
Using CGI::Escape they now get '/pet/Bobby%2FTables' which is correct.
|
Hi @autopp, Thanks for the review :) I've made the change you suggested which has fixed CircleCI. Thanks, Chris |
autopp
approved these changes
Jun 2, 2019
|
@ccouzens The PR was merged. Thank you 👍 |
4 tasks
autopp
pushed a commit
that referenced
this pull request
Jun 5, 2019
`URI.encode` is obsolete. `CGI.escape`, `URI.encode_www_form` or `URI.encode_www_form_component` are recommended instead. https://ruby-doc.org/stdlib-2.6/libdoc/uri/rdoc/URI/Escape.html#method-i-escape URI.encode has different behaviour to CGI.escape: ```ruby URI.encode('hello/world?test%string') => "hello/world?test%25string" CGI.escape('hello/world?test%string') => "hello%2Fworld%3Ftest%25string" ``` I recently raised pull request #3039 201cbdc That pull request escapes path items at insertion. Before either pull request, the path item 'hello?world' would go into the URL as 'hello?world'. That behaviour was insecure as if an attacker could control the path item value, they could change the URL the application connected to. After #3039 'hello?world' would go in as 'hello%253Fworld'. This was safer than before, but it's still not correct. If I'd realised at the time, I would have made it correct at the time. What this pull request does is make it go in as 'hello%35world', which is correct. ApiClient::build_request_url was URI.encoding the whole path. This wasn't protecting against all undesirable characters in the path items, but was escaping % characters a 2nd time which was unhelpful. I have additionally removed URI.encode from Configuration::base_url as I can't see any benefit it could be bringing. There is no justification for it in the commit where it was originally added: 47c8597
jimschubert
added a commit
to jimschubert/openapi-generator
that referenced
this pull request
Jun 5, 2019
* 4.1.x: (56 commits) sync master Update compatibility table Ruby client: escape path parameters (OpenAPITools#3039) [gradle plugin] Release 4.0.1 fixes (OpenAPITools#3051) Update version to 4.0.2-SNAPSHOT (OpenAPITools#3047) Map number to double time since float is also parsed as double in Qt5 C++ (OpenAPITools#3046) Prepare 4.0.1 release (OpenAPITools#3041) [gradle] Reworking publishing pipeline (OpenAPITools#2886) [typescript-fetch] Fix uploading files (OpenAPITools#2900) Resolves OpenAPITools#2962 - Add properties config to Maven parameters (OpenAPITools#2963) fix(golang): Check error of xml Encode (OpenAPITools#3027) [C++][Restbed] Add handler callback methods (OpenAPITools#2911) Remove null checks for C# value types (OpenAPITools#2933) [python-server] Support python 3.7 for all server-generators (OpenAPITools#2884) Use golang's provided method names (gin) (OpenAPITools#2983) [python] Adding constructor parameters to Configuration and improving documentation (OpenAPITools#3002) Add new option to maven plugin's readme (OpenAPITools#3025) Engine param in maven plugin. (OpenAPITools#2881) Added support for patterns on model properties (OpenAPITools#2948) [csharp] Make API response headers dictionary case insensitive (OpenAPITools#2998) ...
6 tasks
4 tasks
4 tasks
autopp
pushed a commit
that referenced
this pull request
Jun 24, 2019
URL-special characters such as /,?,% should be encoded when inside path parameters. I changed the Ruby-client to do so. #3039 Unfortunately, some projects relied on slashes not being expanded within path paramters: #3119 With this commit, these projects can now pass `--strict-spec false` to not have / converted to %2F. strict spec not specified: / -> %2F --strict-spec true: / -> %2F --strict-spec false: / -> /
therve
pushed a commit
to DataDog/datadog-api-client-ruby
that referenced
this pull request
Mar 23, 2021
URL-special characters such as /,?,% should be encoded when inside path parameters. I changed the Ruby-client to do so. OpenAPITools/openapi-generator#3039 Unfortunately, some projects relied on slashes not being expanded within path paramters: OpenAPITools/openapi-generator#3119 With this commit, these projects can now pass `--strict-spec false` to not have / converted to %2F. strict spec not specified: / -> %2F --strict-spec true: / -> %2F --strict-spec false: / -> /
therve
added a commit
to DataDog/datadog-api-client-ruby
that referenced
this pull request
Mar 23, 2021
* [Ruby] Rename files/folders (#534)
* Rename templateDir: rails5 -> ruby-on-rails-server
* Rename script: rails5-petstore-server.sh -> ruby-on-rails-server-petstore.sh
* Rename sample folder: rails5 -> ruby-on-rails
* Rename script(openapi3): rails5-petstore-server.sh -> ruby-on-rails-server-petstore.sh
* Update ruby-on-rails-server-petstore.sh
* Rename templateDir: sinatra -> ruby-sinatra-server
* Rename script: sinatra-petstore-server.sh -> ruby-sinatra-server-petstore.sh
* Rename sample folder: sinatra -> ruby-sinatra
* Update script
* Rename templateDir: ruby -> ruby-client
* Rename script: ruby-petstore.sh -> ruby-client-petstore.sh
* Update scripts
* Update samples
- bin/ruby-sinatra-server-petstore.sh
- bin/ruby-on-rails-server-petstore.sh
- bin/ruby-client-petstore.sh
- bin/security/ruby-client-petstore.sh
* [Ruby] Better handling of operationID starting with a number (#719)
* better handling of operationId starting with numbers in Ruby
* update Rubocop to use Layout
* #714 prevent throwing another exception if the request fails eg connection reset (#715)
* prevent throwing another exception if the request fails eg connection reset
* prevent throwing another exception if the request fails eg connection reset
* [Ruby] Fix method split (#780)
* Fix methods split for readable
* Recreate sample
* Generate a Gemfile.lock for the Ruby client, to keep versions consistent when running automated tests (#966)
* Added pry-byebug to debug Ruby client (#979)
* add nullable to Ruby client (#1059)
* Add "servers" support to Ruby API client (#1280)
* update ruby samples with OAS3 spec
* add server support to ruby api client
* minor format change
* minor format fix, skip form models
* better exception and add test for invaid value
* remove exception test code
* Added tests and fix for issue #1392. Fix regex generated in Ruby client. (#1393)
* Added tests and fix for issue #1392. Param validation with regex not recognizing \d correctly in Ruby client.
* Added generated files to pass ./bin/utils/ensure-up-to-date which is run by circleci
* Fix return_type parameter examples in ruby-client (#1399)
* Fix return_type parameter examples
* $ bin/openapi3/ruby-client-petstore.sh
* Better OpenAPI spec v3 support: allOf, anyOf, oneOf (#1360)
* add oneOf support to Ruby
* add anyOf support to ruby client
* add discriminator support to ruby client
* fix typo
* update samples, fix NPE
* better format in ruby generator
* fix test cases, disable mapping test
* fix update script, update samples
* add test, fix mapping
* update exit code
* reenabled discriminator test
* remove duplicated properties
* add test for duplicated properties
* update samples, add new spec
* fix ruby test cases
* fix hasMore after removing duplicates
* refactor method, comment out haskell client test
* fix hasMore and update samples
* fix parent detection
* fix discriminator check
* [haskell-http-client] need to use {{vars}}{{required}} instead of {{requiredVars}}
* remove deprecated methods in default codegen (#1031)
* regenerate samples
* remove commented code
* Improve model class of ruby-client (#1670)
* Add Model.build_from_hash
* Use Model.build_from_hash instead of Model.new.build_from_hash
* Update sample for ruby-client
* Update sample for openapi3 ruby-client
* Fix various typos in the templates (Ruby, C#) (#1803)
* Fix typos
* update petstore samples
* fix index check, add test cases (#1993)
* [Ruby] Use double-quote string to enable string interpolation (#2067) (#2068)
* [Ruby] Fix Ruby client to prevent Rubocop's rule violations (#2100) (#2102)
* [Ruby] Delete empty lines and trailing newline in template to prevent Rubocop's rule violation (#2100)
* [Ruby] update samples of Ruby client (#2100)
* [Ruby] Fix enum expansion in Ruby client (#2081) (#2104)
* use double-quote string for enum value (#2081)
* use enumVars in templates for Ruby client (#2081)
* delete unnecessary line in enum model of Ruby client (#2081)
* update samples of Ruby client (#2081)
* [Ruby] Fix regualr expression in error message (#2069) (#2139)
* Fix usage of regular expression literals in Ruby client (#2069)
* update samples of Ruby client (#2069)
* [Ruby] various improvements (#2226)
* add to_s in api error class
* rename variable to align with code sample
* fix initalize, better validation
* update petstore samples
* add code sample for model
* add auto-generated travis file
* improve error message
* add travis file
* uncomment to_s
* update ZenTest (#2289)
* update ZenTest
ZenTest 4.11.1 requires rubygems 2.x.
But Ruby 2.6.0 include rubygems 3.x.
So we can't use ruby client in Ruby 2.6.0.
https://www.ruby-lang.org/en/news/2018/12/25/ruby-2-6-0-released/
ZenTest 4.11.2 removed rubygems dependency so we should update.
https://github.com/seattlerb/zentest/commit/1883b210aa3dc2377e2d3571f95a5e462c0e1ce7
* update ruby client sample
* Outputs dataType to YARD tag (#2329)
* output dataType to YARD tag
YARD supports parameter type tag.
https://www.rubydoc.info/gems/yard/file/docs/Tags.md#param
We can use `dataType` as parameter type.
So it's very useful to output `dataType`.
* update samples
* [Ruby] Fix type mapping for Ruby (#2385) (#2386)
* maps 'boolean' to 'Boolean' in Ruby (#2385)
* update Ruby client samples (#2385)
* Add RuboCop to Gemfile (#2464)
* Add Rubocop
* Update samples
./bin/openapi3/ruby-client-petstore.sh
./bin/ruby-client-petstore.sh
* [Ruby] Use Integer instead of Fixnum in Ruby client (#2475) (#2481)
* use Integer instead of Fixnum in Ruby client (#2475)
* update samples (#2475)
* [#2441] Update documentation mustache templates for proper linting. (#2458)
* [#2441] Update documentation mustache files for PHP client
This commit fixes issues with Markdown/CommonMark parsing by linting and enforcing consistent style.[#2441]
Issues with generated markdown files as reported by markdownlint for node.js are:
- MD001 heading-increment/header-increment - Heading levels should only increment by one level at a time
- MD002 first-heading-h1/first-header-h1 - First heading should be a top level heading
- MD007 ul-indent - Unordered list indentation
- MD009 no-trailing-spaces - Trailing spaces
- MD010 no-hard-tabs - Hard tabs
- MD011 no-reversed-links - Reversed link syntax
- MD025 single-h1 - Multiple top level headings in the same document
- MD031 blanks-around-fences - Fenced code blocks should be surrounded by blank lines
- MD032 blanks-around-lists - Lists should be surrounded by blank lines
- MD040 fenced-code-language - Fenced code blocks should have a language specified
- MD041 first-line-h1 - First line in file should be a top level heading
* [#2441] Update documentation mustache files for ruby client
This commit fixes issues with Markdown/CommonMark parsing by linting and enforcing consistent style.[#2441]
Issues with generated markdown files as reported by markdownlint for node.js are:
- MD001 heading-increment/header-increment - Heading levels should only increment by one level at a time
- MD002 first-heading-h1/first-header-h1 - First heading should be a top level heading
- MD007 ul-indent - Unordered list indentation
- MD009 no-trailing-spaces - Trailing spaces
- MD010 no-hard-tabs - Hard tabs
- MD011 no-reversed-links - Reversed link syntax
- MD025 single-h1 - Multiple top level headings in the same document
- MD031 blanks-around-fences - Fenced code blocks should be surrounded by blank lines
- MD032 blanks-around-lists - Lists should be surrounded by blank lines
- MD040 fenced-code-language - Fenced code blocks should have a language specified
- MD041 first-line-h1 - First line in file should be a top level heading
* [#2441] Update documentation mustache files for javascript client
This commit fixes issues with Markdown/CommonMark parsing by linting and enforcing consistent style.[#2441]
Issues with generated markdown files as reported by markdownlint for node.js are:
- MD001 heading-increment/header-increment - Heading levels should only increment by one level at a time
- MD002 first-heading-h1/first-header-h1 - First heading should be a top level heading
- MD007 ul-indent - Unordered list indentation
- MD009 no-trailing-spaces - Trailing spaces
- MD010 no-hard-tabs - Hard tabs
- MD011 no-reversed-links - Reversed link syntax
- MD025 single-h1 - Multiple top level headings in the same document
- MD031 blanks-around-fences - Fenced code blocks should be surrounded by blank lines
- MD032 blanks-around-lists - Lists should be surrounded by blank lines
- MD040 fenced-code-language - Fenced code blocks should have a language specified
- MD041 first-line-h1 - First line in file should be a top level heading
* [#2441] Update documentation mustache files for Java client
This commit fixes issues with Markdown/CommonMark parsing by linting and enforcing consistent style.[#2441]
Issues with generated markdown files as reported by markdownlint for node.js are:
- MD001 heading-increment/header-increment - Heading levels should only increment by one level at a time
- MD002 first-heading-h1/first-header-h1 - First heading should be a top level heading
- MD007 ul-indent - Unordered list indentation
- MD009 no-trailing-spaces - Trailing spaces
- MD010 no-hard-tabs - Hard tabs
- MD011 no-reversed-links - Reversed link syntax
- MD025 single-h1 - Multiple top level headings in the same document
- MD031 blanks-around-fences - Fenced code blocks should be surrounded by blank lines
- MD032 blanks-around-lists - Lists should be surrounded by blank lines
- MD040 fenced-code-language - Fenced code blocks should have a language specified
- MD041 first-line-h1 - First line in file should be a top level heading
* [#2441] Update documentation mustache files for GO client
This commit fixes issues with Markdown/CommonMark parsing by linting and enforcing consistent style.[#2441]
Issues with generated markdown files as reported by markdownlint for node.js are:
- MD001 heading-increment/header-increment - Heading levels should only increment by one level at a time
- MD002 first-heading-h1/first-header-h1 - First heading should be a top level heading
- MD007 ul-indent - Unordered list indentation
- MD009 no-trailing-spaces - Trailing spaces
- MD010 no-hard-tabs - Hard tabs
- MD011 no-reversed-links - Reversed link syntax
- MD025 single-h1 - Multiple top level headings in the same document
- MD031 blanks-around-fences - Fenced code blocks should be surrounded by blank lines
- MD032 blanks-around-lists - Lists should be surrounded by blank lines
- MD040 fenced-code-language - Fenced code blocks should have a language specified
- MD041 first-line-h1 - First line in file should be a top level heading
* [#2441] Update documentation mustache files for Rust client
This commit fixes issues with Markdown/CommonMark parsing by linting and enforcing consistent style.[#2441]
Issues with generated markdown files as reported by markdownlint for node.js are:
- MD001 heading-increment/header-increment - Heading levels should only increment by one level at a time
- MD002 first-heading-h1/first-header-h1 - First heading should be a top level heading
- MD007 ul-indent - Unordered list indentation
- MD009 no-trailing-spaces - Trailing spaces
- MD010 no-hard-tabs - Hard tabs
- MD011 no-reversed-links - Reversed link syntax
- MD025 single-h1 - Multiple top level headings in the same document
- MD031 blanks-around-fences - Fenced code blocks should be surrounded by blank lines
- MD032 blanks-around-lists - Lists should be surrounded by blank lines
- MD040 fenced-code-language - Fenced code blocks should have a language specified
- MD041 first-line-h1 - First line in file should be a top level heading
* [#2441] Update documentation mustache files for C# client
This commit fixes issues with Markdown/CommonMark parsing by linting and enforcing consistent style.[#2441]
Issues with generated markdown files as reported by markdownlint for node.js are:
- MD001 heading-increment/header-increment - Heading levels should only increment by one level at a time
- MD002 first-heading-h1/first-header-h1 - First heading should be a top level heading
- MD007 ul-indent - Unordered list indentation
- MD009 no-trailing-spaces - Trailing spaces
- MD010 no-hard-tabs - Hard tabs
- MD011 no-reversed-links - Reversed link syntax
- MD025 single-h1 - Multiple top level headings in the same document
- MD031 blanks-around-fences - Fenced code blocks should be surrounded by blank lines
- MD032 blanks-around-lists - Lists should be surrounded by blank lines
- MD040 fenced-code-language - Fenced code blocks should have a language specified
- MD041 first-line-h1 - First line in file should be a top level heading
* [#2441] Update documentation mustache files for Android client
This commit fixes issues with Markdown/CommonMark parsing by linting and enforcing consistent style.[#2441]
Issues with generated markdown files as reported by markdownlint for node.js are:
- MD001 heading-increment/header-increment - Heading levels should only increment by one level at a time
- MD002 first-heading-h1/first-header-h1 - First heading should be a top level heading
- MD007 ul-indent - Unordered list indentation
- MD009 no-trailing-spaces - Trailing spaces
- MD010 no-hard-tabs - Hard tabs
- MD011 no-reversed-links - Reversed link syntax
- MD025 single-h1 - Multiple top level headings in the same document
- MD031 blanks-around-fences - Fenced code blocks should be surrounded by blank lines
- MD032 blanks-around-lists - Lists should be surrounded by blank lines
- MD040 fenced-code-language - Fenced code blocks should have a language specified
- MD041 first-line-h1 - First line in file should be a top level heading
* Update README.mustache
* [#2441] Update documentation mustache files for Ada client
This commit fixes issues with Markdown/CommonMark parsing by linting and enforcing consistent style.[#2441]
* [#2441] Update documentation mustache files for Apex client
This commit fixes issues with Markdown/CommonMark parsing by linting and enforcing consistent style.[#2441]
* [#2441] Update documentation mustache files for bash
This commit fixes issues with Markdown/CommonMark parsing by linting and enforcing consistent style.[#2441]
* Pass opts argument to api client in ruby-client (#2754)
* Pass opts argument to api client in ruby-client
We want to change the option when debugging, changing timeout to specific api, etc...
So we want to merge and pass options to api client.
* fix ruby-client
* fix openapi ruby-client
* fix typo
* fix template
* [Ruby] update TargetRubyVersion in .rubocop.yml to 2.4 (#2876)
* Minor wording change (#2875)
* better wording for version of openapi doc
* update petstore samples
* Add support of Bearer Basic Authorization to Ruby client (#2856)
* Support for Bearer in Ruby Client
* Update README.mustache
* Update README.mustache
* Update api_doc.mustache
* Update api_doc.mustache
* Update api_doc.mustache
* samples
* Uncommited changes
* Formatting
* More Formatting
* Fomatting
* More formatting
* More formatting
* Even more formatting
* Even more formatting
* More formatting
* Even more formatting
* More formatting
* More formatting
* Ruby client: escape path parameters (#3039)
* Ruby client: escape path parameters
Path parameters should be escaped when encoded into the path.
In the path '/pet/{petId}' let's pretend petId is a string instead of a
number.
If the user uses "Bobby" as the petId then they correctly get the path
'/pet/Bobby'.
But if they put 'Bobby/Tables' as the petId then they used to get the
path '/pet/Bobby/Tables' which will be interpreted by the server as a
different route.
Using CGI::Escape they now get '/pet/Bobby%2FTables' which is correct.
* Ruby client- regenerate further files
Thank you @autopp for noticing I needed to update
`samples/openapi3/client/petstore/ruby`.
Regenerated by running `bin/openapi3/ruby-client-petstore.sh`.
PR #3039
* Ruby: Avoid double escaping path items (#3093)
`URI.encode` is obsolete. `CGI.escape`, `URI.encode_www_form` or
`URI.encode_www_form_component` are recommended instead.
https://ruby-doc.org/stdlib-2.6/libdoc/uri/rdoc/URI/Escape.html#method-i-escape
URI.encode has different behaviour to CGI.escape:
```ruby
URI.encode('hello/world?test%string')
=> "hello/world?test%25string"
CGI.escape('hello/world?test%string')
=> "hello%2Fworld%3Ftest%25string"
```
I recently raised pull request #3039
201cbdce29cc6cdbbbe9efcb1afb250a05bc2ffd
That pull request escapes path items at insertion.
Before either pull request, the path item 'hello?world' would go into
the URL as 'hello?world'. That behaviour was insecure as if an attacker
could control the path item value, they could change the URL the
application connected to.
After #3039 'hello?world' would go in as 'hello%253Fworld'. This was
safer than before, but it's still not correct.
If I'd realised at the time, I would have made it correct at the time.
What this pull request does is make it go in as 'hello%35world', which
is correct.
ApiClient::build_request_url was URI.encoding the whole path.
This wasn't protecting against all undesirable characters in the path
items, but was escaping % characters a 2nd time which was unhelpful.
I have additionally removed URI.encode from Configuration::base_url as I
can't see any benefit it could be bringing.
There is no justification for it in the commit where it was originally
added: 47c8597d36a9bc0983ba5c40e2489bb094f9f076
* Fix rubocop obsolescence (#3175)
* Update obsolete rubocop configuration
* Update obsolete rubocop config
* Update obsolete rubocop config
* Ruby-client: Don't encode slashes if strict-spec false (#3204)
URL-special characters such as /,?,% should be encoded when inside path
parameters. I changed the Ruby-client to do so.
https://github.com/OpenAPITools/openapi-generator/pull/3039
Unfortunately, some projects relied on slashes not being expanded within
path paramters:
https://github.com/OpenAPITools/openapi-generator/issues/3119
With this commit, these projects can now pass `--strict-spec false` to
not have / converted to %2F.
strict spec not specified: / -> %2F
--strict-spec true: / -> %2F
--strict-spec false: / -> /
* Ruby client faraday (#3405)
* WIP: add faraday support to Ruby client
* update samples
* bin/console
* https only
* ruby-faraday: Add a gemspec template for faraday
* Add a test for ruby-faraday client options
* Remove Gemfile.lock from ruby-client-faraday
* Implement faraday client
* Problem: can't use Faraday library for ruby clients
Solution: add support for Faraday library
This patch builds on the work started by @meganemura
* Problem: Faraday is set as default library
Solution: Make Typhoeus default
This patch also updates the api_client template for Faraday to include query params with requests.
* [Ruby][Faraday] Various improvements (#3520)
* update ruby faraday oas v2 samples
* skip some default tests in faraday
* add ruby faraday oas v3 client
* add tests, fix url
* add tests to CI
* fix file upload
* undo changes to ruby-client-petstore.sh
* test faraday first
* combine gemspec tempaltes
* test ruby faraday in drone.io
* use smaller image
* update bundler
* use official ruby image
* skip bundler installation
* skip autotest
* install make
* use different image
* skip ruby tests in drone.io
* Problem: faraday ruby client does not respect TLS settings (#3527)
Solution: pass in tls settings to the faraday client
* Use partial for Ruby HTTP libraries (#3539)
* use partial for ruby http libraries
* fix isFaraday
* add back client side validation switch
* remove blank lines
* [Ruby] remove auto-generated Gemfile.lock (#3541)
* remove auto-generated gemlock file
* update test file to conform to rubocop format
* [Ruby] clean up Ruby dev dependencies (#3551)
* clean up ruby dev dependencies
* update ensure uptodate to cover ruby faraday
* using partials in ruby api_client (#3564)
* [Ruby][faraday] Properly pass verify_mode to faraday (#3652)
* fix the model's `valid?` of Ruby client to prevent runtime error (#3670) (#3671)
* Support custom git repository (#3757)
* add gitHost param to GeneratorSettings and related
* parameterize gitHost in READMEs
* parameterize gitHost in go.mod
* parameterize gitHost in git_push
* update petstore samples
* run ./bin/utils/export_docs_generators.sh
* run meta-codehen.sh
* Revert "run meta-codehen.sh"
This reverts commit d6d579f6159186531257cdfdd73b9caf9e9ffeba.
* Revert "run ./bin/utils/export_docs_generators.sh"
This reverts commit 1b81538198d4319fd1b4e97447303e3cc0e8dc99.
* Revert "update petstore samples"
This reverts commit f513add88396707f6991ae2e4920359583ec88f1.
* run ensure-up-to-date
* [Ruby] fix ruby test, update error message (#4041)
* fix ruby test, update error message
* use block
* update template for api client spec
* update test files
* Fix readonly with isReadOnly (#4102)
* fix readonly
* update samples
* Ruby client nullable (#4391)
* Ruby Client: implementation of nullable
* Ruby samples with nullable implementation
* [Ruby] openapi_nullable as a Set and skipping attrs fix
* [Ruby] Fix typo in description (#4624)
* delete unused mustache in ruby-client (#4638)
* remove base_object_spec.mustache from ruby client (#4918)
* [HttpBasicAuth] Use positive isBasicBasic tag instead of negative isBasicBearer (#5095)
* use positive isBasicBasic tag instead of negative isBasicBearer
* use positive isBasicBasic tag instead of negative isBasicBearer
* [Ruby] Fix obsolete configuration of Rubocop and Rubocop's warns (#5417) (#5474)
* fix obsolute configuration in generated .rubocop.yml
* fix style of `expect` with block in generated ruby client's test code
* update sample of ruby client
* fix CVE-2020-8130 (#5483)
* fix request.on_complete message when tempfile is nil (#5745)
* fix request.on_complete message when tempfile is nil
* update faraday client sample
* add openapi3 client samples
* Sync master to 5.0.x (#5968)
* Change the Model template (#5222)
* Add a link to Xero blog post (#5426)
* Removal of Encoding in the Query-Params in order to prevent double Encoding. (#5255)
This way letting WebClient do its Job in encoding the URL.
* update java webclient sample
* [kotlin][client] Add Jackson as serialization library (#5236)
* [kotlin][client] Add Jackson as serialization library
* [kotlin][client] Add kotlin-client-jackson.sh to kotlin-client-all.sh
* update kotlin client samples
* update doc
Co-authored-by: William Cheng <[email protected]>
* include kotlin jackson in CI tests (#5438)
* [Ruby] Add error output (#5428)
* Add error output to the log so that we can make sure why the error occurred
* Fix forbidden method invocation using default charsets
* Update usage.md (#5443)
* fix NPE for enum (#5445)
* [Java][WebClient] better code format (#5433)
* better code format for java webclient
* prefix local varaible with localVar
* fix issue with online service (#5461)
* Support for additionalProperties in the C generator "Client: C" solves #5395 (#5440)
* Support for additionalProperties in the C generator.
* Support for additionalProperties in the C generator.
* [docs] Enable Algolia search (#5472)
* Fix #5420 add headers from configuration object (#5422)
* Fix #5420 add headers from configuration object
* Add baseOptions undefined checking #5420
* Update the samples and replace array to object #5420
* Update sample
* [typescript] Clean up modelPropertyNaming across generators (#5427)
* [typescript] Clean up modelPropertyNaming across generators
Fixes https://github.com/OpenAPITools/openapi-generator/issues/2976
Generators without runtime models conversion use "original" property naming by default. It's still possible to change it via cli options
Generators with runtime conversion keep using "camelCase"
* Refactoring: use enum instead of string for modelPropertyNaming
* Restore the original camelCase for var names, decouple it from property names
* Swap toParamName and toVarName logic (looks like I've mistaken them)
* Regenerate docs
* Remove a no longer used private method
* Added support for msvc builds in cpp-qt5-client generator (#5468)
* Added support for msvc builds
Moved GCC-specific compile flags to non msvc builds, and added equivalent flags for msvc.
* CMakeLists condition cleanup
* [all] Move feature set setter (#5460)
When I originally implemented the feature set code, I added the
getter/setter on DefaultCodegen and CodegenConfig as well as on
GeneratorMetadata. GeneratorMetadata also includes the library variation
features. When I went to add library-specific features, I realized the
discrepancy.
This removes the public setter from DefaultCodegen/CodegenConfig, and
adds a protected modifyFeatureSet which accepts a lambda and hides the
builder logic away in the method.
This will be a breaking change for anyone who's created a custom
generator in 4.2.3, so the impact is very limited.
* [Swift5] small improvements to Objc compatibility (#5410)
* [swift] make some small improvements
* [swift][client] revert model to use allVars
* PostProcessModelProperty with allVars
* PostProcessModelProperty with vars
* [swift] improve objc interoperability
* [swift] fix swift4 for CI to pass
* [swift] improve objc interoperability
* [swift] improve objc interoperability
* Swift - try to fix build
* [swift] remove pods from git
* [scala] [template] scala sttp client (#5429)
* scala-sttp-client template
* invoker for sttp fixed and tests added
* clean up pet api test from redunant comments
* docs updated
* fix artefact name, model comments and redunant generic
* code optimization
* cross scala versions 2.11 2.12 2.13
* date serializers extracted and joda enabled as default
* basic and bearer authorization added, apikey in query supported
* [Ruby] Fix obsolete configuration of Rubocop and Rubocop's warns (#5417) (#5474)
* fix obsolute configuration in generated .rubocop.yml
* fix style of `expect` with block in generated ruby client's test code
* update sample of ruby client
* [scala] strip model class name for all scala generators (#5439)
* stripped parameter enabled for all scala based generators
* scala samples updated
* docs generators updated
* fix scalatra. regenerated by openapi3 script.
manually removed enum default value from scalatra example due bug in schema extraction
* [Scala][sttp] various improvements (#5475)
* various improvements to scala sttp
* update ScalaSttpClientCodegen.java
* add windows batch file
* test scala sttp in jdk8
* fix tempalte directory
* Use the dataType if the baseType is not set (#5372)
* Use the dataType if the baseType is not set
* add tests for passing enum as parameter
* updated requirements file in samples
* Update spec to explicitly name objects and prevent `inline_object`
* use the correct scripts to generate samples (`bin/openapi3/python-flask*`)
* [python] Adds python oneOf/anyOf models + tests (#5341)
* Adds oneOf + anyOf schemas, models and tests to python-experimental
* Adds setUpClass and tearDownClass
* Removes newline in method_init_shared.mustache
* Regenerated v3 spec sample for python-experimental
* Fxes test for discard_unknown_keys
* Moves new models into existing spec, regen python-exp and go-exp
* Also fix python-exp windows file
* fix CVE-2020-8130 (#5483)
* [go] Add Ptr method to const enum values (#5257)
* fix rubocop warns in Ruby client's custom spec (#5488)
* [C-libcurl] The name in API parameter should not be escaped even though it includes a C key word. (#5487)
* [go-experimental] Support aliasing of API keys (#4940)
* [go-experimental] Support aliasing of API keys
* Use {{.}} inside condition
* Use name instead of keyParamName for lookup
* x-lookup to x-auth-id-alias
* [java] Support aliasing of API keys (#4966)
* [java] Support aliasing of API keys
* Rebuild Java Jersey2 sample client
* x-lookup to x-auth-id-alias
* Regenerated
* [cli][gradle] Validate now uses parseOptions w/setResolve (#5471)
* [cli] Validate now uses parseOptions w/setResolve
The validate command now uses ParseOptions#setResolve(true) to match how
we parse in CodegenConfigurator and online's Generate. Without this
option, the OpenAPI 3 parser skips the "resolve" block, which made lead
to validations in the command not matching validations during
generation.
* [gradle] Validate now uses parseOptions w/setResolve
The Graldle validate command now uses ParseOptions#setResolve(true) to match how
we parse in CodegenConfigurator and online's Generate. Without this
option, the OpenAPI 3 parser skips the "resolve" block, which made lead
to validations in the command not matching validations during
generation.
* [kotlin]Fix ktor doesn't generate nullable types (#5258)
* If not required, need `? = null`
* run ./bin/kotlin-server-petstore.sh
* Added `?` when value is `required` and `isNullable`
* Rerun ./bin/kotlin-server-petstore.sh. But No differences
* [C++] Add an option to allow having lowercase variables in models, Pistache: allow using reservedWords in models (#5434)
* [C++][Pistache] Use reserved words to replace incorrect names
discard old decision to truncate reservedWords
* [C++][Pistache] Update struct model to use name instead of baseName
* [C++][Pistache] Update Petstore sample
* [C++] Add option to have lowercase variables
* [C++] Update generated docs
* [BUG] [JAVA | Spring] Cookie in parameter is not correctly generated (#5393)
* Cookie in parameter is not correctly generated
* gh-5386: Fix cookie parameter in
* gh-5386: Fix cookie parameter in
* gh-5386: Update test file
* gh-5386: Fix cookie parameter in
* gh-5386: Fix cookie parameter in
* gh-5386: Regenerate samples
* gh-5386: Fix test
* Added Spring CookieValue tests
Co-authored-by: Gonzalo <[email protected]>
* Add missing `@Generated` annotation. (#5384)
The annotation is present on other generated files when using jaxrs-spec, but it missing on model classes.
* [scala] [template] scala model property style (#5486)
* Model property naming style generic for scala
* scala templates based on abstractScala regererated
* docs generators updated
* property format tests
* add Agoda as the user (#5494)
* Hide timestamp in Scala Play server samples (#5495)
* hide timestamp in scala play server output
* add chameleon82 to scala tech committee
* Add a link to tech blog tech.medpeer.co.jp (#5498)
* Add links to blog posts about OpenAPI Generator (#5508)
* Typescript array alias array (#4981)
* Add failing tests for typescript type declaration
* Refactor array and map child type string fallback
* Add unaliasSchema to typescript getTypeDeclaration
* TypeScriptRxjs: Use Blob as file type declaration
This was inadvertantly changed in
https://github.com/OpenAPITools/openapi-generator/pull/5266
* [core] Sanitize/underscore/camelize cache expiry (#5484)
The helper methods for sanitize/underscore/camelize were recently
updated to cache values in static maps. This would lead to a memory leak
in hosted environments as the maps had no cleanup/expiry.
This moves those cached entries to Caffeine caches with expiry based on
last access to allow the edge-case performance improvement gains on very
large documents, without the memory leak in hosted or embedded
environments.
* Update README.md
* Add a link to the conference paper (#5510)
* Add a link to the conference paper
* fix author list
* [Slim4] Add Data Mocker middleware (#4978)
* [Slim4] Store response schemas
* [Slim4] Add Data Mocker middleware
* [Slim4] Enhance Slim router
* [Slim4] Enhance config
* [Slim4] Fix data format key in object mocking
* [Slim4] Add tests for Data Mocker middleware
* [Slim4] Add Mock feature documentation
* [Slim4] Refresh samples
* [Java][Spring][Spring-Cloud] Fix #5144 - Use conditional package declaration to avoid unnecessary dependencies (#5145)
* FIX: Use conditional package declaration to avoid unnecessary dependencies
* DEV: Adjusted sample ClientConfiguration.java for async spring-cloud
* fix(php): no need to serialize collections, Guzzle does that, fix #2292 (#3984)
* fix(php): only serialize collections if !explode, Guzzle handles the rest, fix #2292
* fix(php): update petstore samples
Co-authored-by: Mahdi Dibaiee <[email protected]>
* [php] replace $collectionFormat with $style (#5517)
* php - remove $collectionFormat
* update php openapi3 petstore sample
* [BUG][scala][template] scala generate java.math.BigDecimal instead of scala type (#5514)
* [BUG] scala generate java.math.BigDecimal instead of scala type
* update docs/generators
* [PHP] complete support for form style (#5519)
* [BUG][PHP] Parameter property style not fully implemented (related to comment on PR #3984)
* [AUTOGENERATED][PHP] Sample Files
* update jackson dependency to newer version (#5527)
* Fix Swift4 CI tests (#5540)
* comment out swift 4 order tests
* comment out store tests
* Test Dart petstore client in CircleCI (#5544)
* test dart2 in circle ci (jdk7)
* fix tests
* update package
* fix dart installation
* Add serialization of ModelComposed (#5551)
* Fixes kwargs typos, removes E501s (#5552)
* Update generic model to support nullable properties (#5568)
* [DOC] Add link to integration test wiki in CONTRIBUTING.md (#5570)
* Add link to integration test wiki
* Add link to integration test wiki
* [Kotlin][client] fix file upload (#5548)
* [kotlin] fix file upload
* [kotlin] fix file upload
* [kotlin] fix file upload
* [kotlin][client] fix jackson integration
* [kotlin] fix file upload
* [kotlin] fix file upload
* update doc
* [Java] Fix exception when OAuth2 token URL is a relative URL (#5535)
* Add support for case when OAuth2 token URL is a relative URL
* Add support for case when OAuth2 token URL is a relative URL
* run scripts under bin
* [Java] fix runtime exception when there are multiple auth methods (#5530)
* fix runtime exception when there are multiple auth methods
* Refactor a bit so that it does not cause conflict with relative url token branch
* [markdown] Fix broken links when generating markdown (#5569)
* [markdown] Fix broken links when generating markdown
The `api.mustache` file generates links to the markdown model files.
These links were previously brokeen.
Additionally, the defaultPackage for markdown is "/Models", so this
looked pretty in the heading for model files. So this prefix has been
stripped from the header in `model.mustache`.
* Re-generate Petstore samples for markdown
* typescript-angular: fix zone-js version for angular 8 (#5585)
* Add a link to the slide (#5590)
* [Swift] fix URLSession file upload (#5546)
* [swift5] - fix URLSession file upload
* [swift5] - fix URLSession file upload
* [swift5] fix file upload
* [swift5] - fix URLSession file upload
* [swift] add unit tests for file upload
* [swift] update samples copyright
* [swift] add option for API prefix (#5567)
* [swift] add option for API prefix
* [swift] update docs
* [haskell-http-client] update stack; exclude problem time versions (#5589)
* [go-experimental] Do not generate HTTP signature unit test for every generated SDK (#5588)
* Do not generate HTTP signature unit test for every generated SDK
* Add golang 1.14 to CI environment
* fix unit test issues
* remove script commands that were commented out
* add support for ed25519 private keys
* PR to solve 2 open issues on enums: #5091 and #4293 (#5477)
* PR to solve 2 open issues on enums:
Issue 5091 needs to generate enums also when the enum is directly in a param to a API call, instead than in a model. I did that by copying and adapting enum code from *model* to *api*
Issue 4293 needs to decorate enums, for when enum names or enum values are repeated over the yaml definition.
* PR to solve 2 open issues on enums:
Issue 5091 needs to generate enums also when the enum is directly in a param to a API call, instead than in a model. I did that by copying and adapting enum code from *model* to *api*
Issue 4293 needs to decorate enums, for when enum names or enum values are repeated over the yaml definition.
* Enums decorated: with {{projectName}}_{{classVarName}}_{{enumName}}_ in the models, with {{projectName}}_{{classVarName}}_{{enumName}}_ in the operations.
* Changes to the c client:
- Removed white space.
- Removed ToJSON and FromJSON function for the enums, since they are not used
- Sanitized project name in the .java file. For example, this solves a problem with the issue #2338, where the yaml file had title: "Skycoin REST API."
* Changes to the c client:
- Removed white space.
- Removed ToJSON and FromJSON function for the enums, since they are not used
- Sanitized project name in the .java file. For example, this solves a problem with the issue #2338, where the yaml file had title: "Skycoin REST API."
* Adds parseFlattenSpec (#5526)
* Adds parseFlattenSpec, updates tests and helper functions
* Adds parseSPec invocation inside parseFlattenSpec
* Scala-Akka: Add missing body to PATCH requests (#5605)
* NodeJS - Adds missing keyword (#5606)
* [jaxrs-cxf-cdi] Support PATCH httpMethod (#5574)
Update the required CXF version to 3.1.2 since PATCH support appeared
with this version.
Add the cxf PATCH annotation to the imports so that the generated code
when defining a PATCH api compiles.
* fix default value for abstract scala and scalatra server impl (#5578)
* [Java] Generated API class has wrong dataType and does not compile Issue (#5331)
* add unit test assertion
* add check for composed schema
* add support for x-allOf-name
* change x-allOf-name to x-all-of-name
* Add more troubleshooting information
* Add more troubleshooting information
* Add more troubleshooting information
* Add more troubleshooting information
* [swift5] stop hiding network error (#5603)
* [swift5] stop hiding network error
* [swift5] stop hiding network error
* [scala][templates] java 8 dates support (#5291)
* [scala][akka-http-client] java8 dates support
* scala-akka readme doc updated
* DateSerializers renamed
* rename serializers
* move date-library option to abstractScala
* generators docs updated
* enum defined for date libraries
* Backport to scala-http-client
* fix scala-akka-client date serializers
* fix typo in docs
* switch scala templates to java8 (jsr-310) date library by default
* update scala samples with java8 date library
* update scala generators docs with java8 default date library
* fix scala-play-server generator cli options as only java8 dateLibrary supported
* fix scalaz DateTimeCodecs template to support java8
* scalaz ci test againt java7 removed as it generate scala 2.11.8 client which is java8 based
* update doc
* Adding Response Interceptor (#5500)
* added Response interceptor for native clients
* added Response interceptor for native clients
* [k6] Add blog post about using the k6 generator (#5608)
* [Kotlin] Remove kotlin-reflect dependency when not needed (#5502)
* Remove kotlin-reflect dependency when using CodeGen
* Update Kotlin tests
* Regenerated unit test samples
* Remove newline in generated build.gradle files
* [typescript-fetch] add interfaces, withInterfaces (#5612)
* typescript-fetch: interfaces, first draft
* fix name in description
* [scala] Regenerate akka sample (#5622)
* scala-version 2.11.12 (#5618)
* micheleISEP->michelealbano (#5625)
* [Powershell] refactor the client generator (#5629)
* add api client
* add local variables
* add configuration
* add header/query/form parameter support
* add partial header
* add auth, fix parameters type
* fix accept, content type
* url query string
* fix path, header
* remove dep on C# client
* fix method naming with package name
* fix object
* convert result from json
* better response handling
* remove tostring method
* fix model doc
* fix default module
* generate api test files
* better api, model tests
* fix add pet
* add appveyor
* fix accept, content type
* add petstore tests
* fix form parameters
* test delete
* better file handling (upload)
* better code sample
* add package version, better doc
* delete unused files
* fix header parameters
* clean up api client
* update samples
* support query parameter
* better method and parameter naming
* minor formatting change
* better doc, fix cookie parameter
* better doc
* add api prefix support
* better api nam prefix option
* fix configuration
* throw errors for required parameter
* fix authentication
* add try catch block to sample code
* rename model
* use debug, clean up comment
* revise code
* move bin script
* update doc
* add new file
* better map support
* [PowerShell] minor improvements and bug fixes (#5635)
* add output type, minor format fix
* minor test improvement
* Port client updates to server (#5634)
* Revert "scala-version 2.11.12 (#5618)"
This reverts commit 6b984a926a0f99120a4ad80cef73bee19f8614cd.
* update release date
* Handle negative response from the server (#5649)
* Fix integration tests (Travis, CircleCI) (#5672)
* fix php tests
* fix scala tests
* update ts angular v6 rest
* fix user create test
* fix spring cloud test
* comment out user delete
* fix angular v7 tests
* fix user test
* fix tests
* fix go exp tests
* commented out delete user tests
* comment out delete user tests in go openapi 3
* fix clojure tests
* [PowerShell] Fixes typo (#5648)
* Solving issue #5623 and supporting bools for C client label:"Client: C" (#5624)
* Removed stray "printf"s in
modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/CLibcurlClientCodegen.java
* Support for booleans in C client
* Update README.md
* Change to C API mustache files to solve issue #5623
* Debugging of C's modle-body.mustache, as suggested by ityuhui
* Final changes suggested by ityuhui
* [PowerShell] Fix map type (#5638)
* fix map type
* remove output type, fix appveyor
* test macos
* comment out failing scala test
* fix typo: configuration
* Revert "comment out failing scala test"
This reverts commit 1dcf84ffcbb7ab520938ae7c75d60a8329f71478.
* [powershell-experimental] Protects against stackoverflow when OAS spec has circular references (#5646)
* protects against stackoverflow when OAS spec has circular references
* protects against stackoverflow when OAS spec has circular references
* Adds configuration option to skip certificate check. Fixes a typo. Fixes an issue which was restricting from cookie to get consumed (#5657)
* [k6] bugfixes to improve the output script (#5614)
* [k6] Skip appDescription escaping
* [k6] Fix variable identifier in output
* [k6] Fix bug with reserved words handling
* [C][Client] Check the pointer before deleting operation to avoid core dump label:"Client C" (#5626)
* [C-libcurl] Check the pointer before deleting operation to avoid core dump
* [C-libcurl] Check the pointer before deleting operation, update sample
* [kotlin][client] Add Jackson to interface properties and remove extra line feed (#5459)
* [kotlin][client] Ensure Jackson annotations are consistent with interface vars
* [kotlin][client] Rebuild samples
* [kotlin][client] Some kotlin client enhancements
- Don't use JsonFormat for Date objects, this should be controlled via
a custom serializer/deserializer or a turning on and off serialization
features of Jackson. I've updated the jacksonObjectMapper config to
write the dates as strings, which I think was intended in the original
commit.
https://fasterxml.github.io/jackson-databind/javadoc/2.6/com/fasterxml/jackson/databind/SerializationFeature.html#WRITE_DATES_AS_TIMESTAMPS
https://fasterxml.github.io/jackson-databind/javadoc/2.6/com/fasterxml/jackson/databind/cfg/MapperConfig.html#getDateFormat--
- Dont' use @JsonFormat(shape = JsonFormat.Shape.OBJECT) for enums.
This causes Enums to be formatted as objects with an internal "value"
field. In reality, OpenAPI enums are just strings without properties
and should be treated as a string.
https://www.baeldung.com/jackson-serialize-enums#2-enum-as-json-object
- Add's Kotlin use site annotation @get: to JsonProperty for parent interface
properties. Otherwise Kotlin will warn:
"This annotation is not applicable to target 'member property without
backing field or delegate'"
- Add's JsonTypeInfo annotations to interfaces for inheritance. This
was copied verbatim from the kotlin-spring generator.
https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/main/resources/kotlin-spring/typeInfoAnnotation.mustache
* [kotlin][client] Rebuild kotlin samples
* Remove scala version in parent pom (#5647)
* [asciidoc] Allow the inclusion of additional documentation to t… (#5260)
* [asccidoc] Allow the inclusion of additional documentation to the asccidoc generated
Resolves #5228
* [jaxrs-reasteasy-eap] Fix invalid Bean Validation annotations for Longs (#5659)
* fix issue #5658
* update samples
* [PowerShell] Test powershell petstore client in Appveyor (#5674)
* remove scala version in parent pom
* test ps petstore in appveyor
* fix command
* build and import
* fix import module
* fix import
* skip module import
* run multiple commands
* move to test script
* test ps exit
* fix exit
* check last status code
* clean tests
* exit last code
* add import
* change dir
* skip build failure
* fix check
* trigger build failure
* fail fast
* restore c# test
* new line comment
* add powershell exp to ensure up to date script
* [PowerShell][Experimental] Better docstring (#5688)
* add docstring to powershell module
* add doc string
* Nodejs express js packages update (#5675)
* Updated to new nodejs packages, depending heavily on express-openapi-validator. Requires quite a change in code.
Updated the business-logic in the controllers/Controller.js file.
Logger now records also timestamp of events.
Files are uploaded according to definition in config.js file
* Removed commented-out code; Changed openApi document extensions to suit new express-openapi-validator definition; multipart and file uploading is supported now; Automatic response returns the values the were sent in the request
* fixed README documentation, fixed a mistage in package.json/mustache
* added generated files that were created when running the ./bin/test file
* [go-experimental] Fix nullable support (#5414)
* Fix nullable support in go-experimental client
* Fix support for models with parents and container fields
* Make sure that oneOf interfaces serialize properly even if they're required (non-pointers) on other models
* Spaces => tabs
* Regenerate samples
* Make some methods of nullables pointer-receivers, add tests
* Improve the Get/Set logic to make usage more convenient
* Address review
* [kotlin][client] make base path globally configurable (#5450)
* [kotlin][client] make base path configurable
* [kotlin][client] update pet project
* [kotlin][client] set default base path
* [kotlin][client] set default base path
* [kotlin][client] set default base path
* Add michelealbano to C technical committee (#5692)
* [Go][Experimental] Rename extensions from x-basetype to x-go-base-type (#5691)
* rename go vendor extension
* update go exp petstore samples oas3
* comment out powershell petstore in uptodate script
* remove processing of http_signature_test.mustache (#5696)
* Fix generation of oneOf interfaces for oneOf usage in properties (#5400)
* Fix generation of oneOf interfaces for oneOf usage in properties
* Only generate oneOf interface models when oneOf is defined
* use basic parsing (#5702)
* [python/asyncio] explicitly close client session via async context manager (#5621)
* [gradle] Include engine option for handlebars generation (#5686)
* [codegen][Go] Fix compilation error of generated go code when schema is free form object (#5391)
* Fix code generation for free-form objects in go-experimental
* Execute scripts in bin directory
* Add more use cases for open-ended types
* Add more use cases for open-ended types
* Add more use cases for open-ended types
* add code comments
* Better name for test properties
* handle scenario when type is arbitrary
* handle interface{} scenario
* handle interface{} scenario
* add helper function isAnyType
* isAnyType function
* implementation of isAnyType function
* fix javadoc issue
* handle interface{} scenario
* use equals comparison instead of ==
* merge from master
* Add code documentation
* add code comments, remove unused min/max attribute, fix equals method
* Handle 'anytype' use case
* add code comments
* override postProcessModelProperty to set vendor extension
* Use vendorExtensions.x-golang-is-container
* fix compilation error of generated code
* fix compilation error of generated code
* fix compilation error of generated code
* [Java] Update version of maven-surefire-plugin (#5509)
* use more recent version of maven-surefire-plugin
* use more recent version of maven-surefire-plugin
* higher debug level for troubleshooting ci issue
* temporarily increase debug log to help troubleshoot
* Use local instance of pet store service for unit test purpose
* Add more logging to troubleshoot unit test failures
* Add more logging to troubleshoot unit test failures
* Add more logging to troubleshoot unit test failures
* Add more logging to troubleshoot unit test failures
* Add more logging to troubleshoot unit test failures
* use random ID for Java unit test instead of fixed id
* add code comments and specify URL for java unit test
* reenable quiet argument
* fix java unit test issues
* fix java unit test issues
* Revert "fix java unit test issues"
This reverts commit e8508416ff0f2aeb568e3f916b013dc967390f74.
* fix java unit test issues
* Generator for JavaScript/Apollo Client (#5645)
Co-authored-by: William Cheng <[email protected]>
* Add yutaka0m to Kotlin Technical Committee (#5716)
* Add Scala client scripts to ensure-uptodate process (#5712)
* add scala client to ensure-upto-date
* new scala-akka petstore oas3 folder
* regenerate scala akka oas2 petstore
* remove script
* Minor improvments to JS apollo generator (#5714)
* minor improvments to js apollo generator
* comment out apollo
* [Rust Server] Handle text/xml correctly (#5660)
* [Rust Server] Handle text/xml correctly
Treat application/xml the same as text/xml as per RFC 7303
* [Rust Server] Add test for text/xml
* Update samples
* 4.3.0 release (#5721)
* update samples (#5722)
* 5211 - Use allVars instead of vars for Kotlin client (#5396)
* [C++] [Qt5] fixed cpp-client-qt5 HttpRequestWorker requests crashing on timeout... (#5651)
* - fixed cpp-client-qt5 HttpRequestWorker requests crashing on timeout when they have actually NOT timed out (were calling back into a deleted struct).
* #minor fixes after review
* Regenerate changed files
Co-authored-by: valentin Bisson <[email protected]>
Co-authored-by: etherealjoy <[email protected]>
* Fix SSL setting in checkout script (#5725)
* fix ssl setting in checkout script
* add check for sbt-openapi-generator
* [C] fix decode funtion (#5642)
* fix function names and add parameter to return decoded bytes length from base64decode function
* format base64decode function to avoid unnecessary malloc and fix wrong length assigning
* update the pointer assigning
for some reason var++ / *var++ cannot be done on int *var, hence making a local variable which is incremented and at the end it is assigned to the pointer.
* Update bump.sh to go SNAPSHOT to version (#5727)
* Fix CI failures (#5734)
* update ci to use petstore 1.0.4
* comment out test
* comment out test
* comment out update user test
* comment out more tests
* use latest petstore
* comment out updatePetWithForm
* comment out update pet test
* fix file path in release_version_update_docs (#5724)
* better appveyor test (#5739)
* better readme, type mapping, new option (#5740)
* Remove warning for unused camel case vendor extension for Qt5 client and server (#5731)
* [PS][Experimental] Add multiple server support (#5741)
* code comment
* add get host setting
* add multiple server support
* add default headers support (#5746)
* [C][Client] Support SSL client authentication for the c client (#5719)
* [C][Client] Support SSL client authentication
* [C][Client] Support SSL client authentication, update sample
* [kotlin] Fix #5247 incorrect enum parameter type for arrays (#5435)
* [Erlang-Server] security definition context changes don't propagate to handler (#5751)
* Map Merge Context & Params
handler requires context and params to be merged before returned to user defined request_handler.
* post build & shell script
* Delete VERSION
* [PS][PowerShell] fix passthru, use switch instead of bool (#5768)
* fix passthru, use switch
* remove line
* comment out kotlin vertx server test (#5767)
* add support for common verbs (#5771)
* fix request.on_complete message when tempfile is nil (#5745)
* fix request.on_complete message when tempfile is nil
* update faraday client sample
* add openapi3 client samples
* use prepare instead of new (#5773)
* use Initialize instead of prepare (#5777)
* add map example (#5778)
* [PS][Experimental] Better common verb handling (#5783)
* better common verb handling
* better debugging
* add option to customize common verb
* [cli][docker] Better expose version/sha information of builds (#5736)
* [cli] Some CLI improvements…
* Introduce --version
* Introduce --help
* Add --sha to version command for short SHA display
* Output Version and SHA details
* In new --version output, display repo and doc site
Additional cleanup to suppress warnings and code quality.
* [docker] Adds labels for metadata
This adds image labels to store metadata on the online and cli docker
images, using standard labels:
* org.opencontainers.image.created
* org.opencontainers.image.revision
* org.opencontainers.image.title
* org.opencontainers.image.version
These can be inspected via 'docker inspect IMAGE_NAME' and may be useful
in tooling/automation or bug reports submitted by users.
For more details on these labels, see:
https://github.com/opencontainers/image-spec/blob/master/annotations.md
* Include version --full for equiv to --version
* [cli] Add --global-property for -D replacement (#5687)
-D option has been deprecated as it was previously used to:
* Pass "system properties"
* Pass additional properties
This was confusing because we already have --additional-properties and
because Java System Properties are passed as -D before program
arguments.
Confusion around the -D option had existed for some time, but when we
introduced the thread-safe GlobalSettings to avoid overwriting Java
System Properties, we created a hard break from Java System Properties
in the generator. This also disconnected the previous "system
properties" from accepting additional properties.
Once these newly deprecated methods are removed, we will have a clear
separation of concerns between:
* Java System Properties
* Global generator properties (used as workflow context)
* Additional properties (used as generator options)
This commit marks multiple places for cleanup in 5.0. These will be
breaking changes, and lower effort to break in 5.0 with deprecation
warnings now rather than adding sibling properties throughout the code
and potentially introducing logic errors.
* [dart-dio] Fixes --model-name-suffix having no effect (#5669)
Fixes #5409
* [go-experimental][go][client] Remove unreachable code in go client API methods (#5611)
* [go-experimental][go][client] Remove unreachable code in go client API methods
* Properly regenerate all samples
* please add openVALIDATION Project to readme (#5534)
* added openVALIDATION Project to readme
* Update README.md
Co-Authored-By: Akihito Nakano <[email protected]>
Co-authored-by: Akihito Nakano <[email protected]>
* [Csharp-client] Complex form parameters are not serialized as application/json (#5787)
* [csharp-client] Complex form parameters are now correctly serialized as json.
Reference: http://spec.openapis.org/oas/v3.0.3#special-considerations-for-multipart-content
* Updated bin/windows csharp sample generation scripts to point to the correct directories
* Updated csharp samples
Co-authored-by: Olivier Leonard <[email protected]>
* fix scala-akka java8 serializers (#5742)
* fix scala-akka java8 serializers
* regenerate samples for akka-http
* [typescript-axios][client] Unnecessary imports occurs when using withSeparateModelsAndApi (#5797)
* add ts-ignore
* add petstore sample
* use write verbose in auth, better api doc (#5804)
* [PS][Experimental] add withHttpInfo support, fix "null" return (#5811)
* add with http support
* use full name in tests
* using full name in test
* skip type check
* [PS][Experimental] Add tests for array of object in response (#5814)
* debugging array response
* fix find pet tests
* better tests to ignore order
* [codegen] Use once(LOGGER) to reduce amount of identical warning messages (#5808)
* Warn once instead of many times when the log statement does not have contextual information
* Warn once instead of many times when the log statement does not have contextual information
* make name cache configurabl (#5775)
* [codegen] Cachesize config seconds (#5816)
* make name cache configurable
* Address review comments
* [Python-experimental] Documentation enhancement for oneOf schema and minor err msg improvement (#5791)
* Add documentation to generated code
* Improve error message
* Improve documentation
* Improve documentation
* Improve documentation
* Improve documentation
* Improve documentation
* Improve documentation
* Run sample scripts
* Address review comments
* Address review comments
* Fix problem in python error message
* rename hostsetting, validate base url (#5821)
* fix array return (#5822)
* Scala akka-http server (#5758)
* Scala akka-http server base implementation
* [scala-akka-http-server] petStore samples
* Improved the formatting of generated files
* Updated scala-akka-http server samples
* [scala-akka-http-server] the groupId, artifactId and artifactVersion default value are used as intended.
* Fixed the default operation not being correctly generated on parameterless operations
* Added build.sbt.mustache supporting file
* Updated scala-akka-http server samples
* ScalaAkkaHttpServer: Fixed a String.format call to use Locale.ROOT for locale
* [scala-akka-http-server] Fixed defaultValue being escaped during generation
* Added scala-akka-http.md
* Replaced all "⇒" character with "=>" to retain compatibility with scala 2.13
* [scala-akka-http] Added a config option akkaHttpVersion
It's set in the generated build.sbt.
* Updated scala-akka-http server samples
* [scala-akka-http] More accurate akkaHttpVersion parsing
* Updated scala-akka-http.md
* [scala-akka-http] Changed the akka-http version check to fix the generation of StringDirectives
* Updated scala-akka-http samples
* updated scala-akka-http.md
Co-authored-by: Olivier Leonard <[email protected]>
* Minor improvements to scala akka server (#5823)
* minor improvements to scala akka server
* add samples
* update doc
* Update swagger parser to 2.0.19 (#5413)
* update swagger parser to 2.0.18
* fix online server exception
* Revert "fix online server exception"
This reverts commit fe3cb5221f362c00b176fa81411eaf368f0e446d.
* update parser to 2.0.19
* [jaxrs-cxf-cdi] fix allOf equals and hashCode (#5756)
When generating model that use allOf, the equals and hashCode methods
must take the parent class into account.
* [BUG] [KOTLIN] Fix default value generation for Kotlin Strings (#5776)
* fix default value generation for kotlin
* add updated pet templates
* Revert "add updated pet templates"
This reverts commit 7e8168ad
* regen pet store projects code
* tests for models for C-libcurl generator (#5699)
* First try to generate unit tests for the models of the C-libcurl client. Models into models are not supported yet.
* Added unit tests for the modules of the C-libcurl client to the git repository.
* Support for objects having other objects as properties, for the C-libcurl client generator
* Proper formatting of generated code
* use allVars to cover all properties (#5835)
* support enum in parameters (#5838)
* [C++] [Qt5] [Client] fixed cpp-client-qt5 HttpRequestWorker contentCompression variables initialization (#5834)
When contentCompression is not enabled, the variables isRequestCompressionEnabled and isResponseCompressionEnabled in HttpRequestWorker are not being initialized.
Without initialization the compress function could be called and the request content could be an empty QByteArray instead of original request body.
* minor fix to http basic auth (#5839)
* Scala akka http server - normalization of some vendor extensions (#5829)
* [scala-akka-http-server] Normalized vendor extension "paths" to "x-paths"
* [scala-akka-http-server] Normalized vendor extension "hasDefaultValue", "isDefault", "specificMarshallers", "fileParams", "nonFileParams"
Co-authored-by: Olivier Leonard <[email protected]>
* Add Bouill to the Scala technical committee (#5843)
* C client generator improvements to support petstore. Solves #5836 (#5837)
* C client generator improvement to support:
openapi-generator/modules/openapi-generator/src/test/resources/3_0/petstore.yaml
* Improvements to the C client generator:
- moved base64* from apiClient.c to binary.h/binary.c
- changed CR/LF to LF in binary.h/binary.c
* C client generator: better support for base64encode / base64decode
* Add openapi.yaml file to Java clients (#5765)
* Add openapi.yaml file to Java client
* Move supporting template file to Java root
* Update petstore clients
* [codegen] Fix 'super.HashCode' for oneOf and allOf Implementations (retry) (#5830)
* Added hasVars after completion of all model post-processing (#5587)
* Post ensure-up-to-date
* Update to check the size of vars and not assume non-null
* update mysql samples
* Add default case to handle response code (#5825)
* add default case to handle response code
* fix default response code
* add test for isDefault
* fix user id in scala tc
* Fix for Issue #4840 [BUG][JAVA][spring-mvc] Generated Code for Map of Maps Return Type does not compile (#5240)
* add parent for allOf only (#5851)
* Add pythonSrcRoot option to python servers (aiohttp/flask/blueplanet) to support src/ layout projects [and reenable/fix all python server tests] (#5423)
* python server: Add pythonSrcRoot option
This will allow the python project to be in a subdirectory (as specified
in pythonSrcRoot). That could mean following the src layout with sources
under src/ or lib/. Multi-language projects might use a sub directory
like python/, or whatever makes sense for the project.
B…
api-clients-generation-pipeline bot
pushed a commit
to DataDog/datadog-api-client-ruby
that referenced
this pull request
Sep 8, 2021
URL-special characters such as /,?,% should be encoded when inside path parameters. I changed the Ruby-client to do so. OpenAPITools/openapi-generator#3039 Unfortunately, some projects relied on slashes not being expanded within path paramters: OpenAPITools/openapi-generator#3119 With this commit, these projects can now pass `--strict-spec false` to not have / converted to %2F. strict spec not specified: / -> %2F --strict-spec true: / -> %2F --strict-spec false: / -> /
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Path parameters should be escaped when encoded into the path.
In the path '/pet/{petId}' let's pretend petId is a string instead of a
number.
If the user uses "Bobby" as the petId then they correctly get the path
'/pet/Bobby'.
But if they put 'Bobby/Tables' as the petId then they used to get the
path '/pet/Bobby/Tables' which will be interpreted by the server as a
different route.
Using CGI::Escape they now get '/pet/Bobby%2FTables' which is correct.
Ruby technical committee:
@cliffano (2017/07) @zlx (2017/09) @autopp (2019/02)
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.master,4.1.x,5.0.x. Default:master.Description of the PR
See top