Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore signing for other branches than master #288

Merged
merged 1 commit into from
Jun 12, 2018
Merged

Ignore signing for other branches than master #288

merged 1 commit into from
Jun 12, 2018

Conversation

jmini
Copy link
Member

@jmini jmini commented Jun 12, 2018

After changes #287 and merge master -> 3.1.x I got this error:

[INFO] --- maven-gpg-plugin:1.6:sign (sign-artifacts) @ openapi-generator-project ---
gpg: keyblock resource `/home/travis/build/OpenAPITools/openapi-generator/sec.gpg': file open error
gpg: skipped "[secure]": secret key not available
gpg: signing failed: secret key not available

Source: https://api.travis-ci.org/v3/job/391192011/log.txt


Input from @jimschubert on Gitter:

Travis doesn't allow unencrypting on non-master branches
you'll need to modify that script to publish without signing, only conditionally.
snapshots don't need to be signed.


This PR does the described modification.

I have tried the command from my local computer:

  • mvn clean deploy -DskipTests=true -B -U --settings CI/settings.xml
  • ./gradlew -PossrhUsername="${SONATYPE_USERNAME}" -PossrhPassword="${SONATYPE_PASSWORD}" uploadArchives --no-daemon

Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@wing328 wing328 added this to the 3.0.2 milestone Jun 12, 2018
@jmini jmini merged commit 9930f61 into master Jun 12, 2018
@jmini jmini deleted the fix_deploy branch June 12, 2018 14:25
@jmini
Copy link
Member Author

jmini commented Jun 12, 2018

Verified on 3.1.x after a merge: master -> 3.1.x.

Travis CI is OK on 3.1.x, Version 3.1.0-20180612.150521-2 was pushed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants