Mention new branches in the doc pages #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wing328
reviewed
Jun 12, 2018
CONTRIBUTING.md
Outdated
| @@ -22,6 +22,10 @@ If you're new to git, you may find the following FAQs useful: | |||
|
|
|||
| https://github.com/openapitools/openapi-generator/wiki/FAQ#git | |||
|
|
|||
| ### Branches | |||
|
|
|||
| See the [Git Branches](https://github.com/OpenAPITools/openapi-generator/wiki/Git-Branches) page. | |||
There was a problem hiding this comment.
I would suggest adding the following:
Please file the pull request against the correct branch, e.g. master for non-breaking changes. See the Git Branches page for more information.
There was a problem hiding this comment.
Implemented. Thank you for the review.
wing328
approved these changes
Jun 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mention the new branches in the docs, add badges
Change in
.travis.yml:3.1.xand4.0.xshould also deploy to distant maven repository