Skip to content

Conversation

@gturri
Copy link
Contributor

@gturri gturri commented May 15, 2025

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

PR #21261 added support for endpoints with response of type text/plain or even image/png.

This commit adds such endpoints (and the subsequently generated samples) so that:

  • the way those are supported is clearer (as it is now directly visible in the generated sample files)
  • if a future commit impacts this part of the generation it will be easier to assess that impact

(nb: first time I'm editing an openapi specification in that repo, I hope I'm doing that commit correctly. Please let me know if I'm doing something wrong, or missing something)

Ping PHP committee: @jebentier @dkarlovi @mandrean @jfastnacht @ybelenko @renepardon

PR #21261 added support for endpoint with response of type text/plain
or even image/png.

This commit adds such endpoint so that:
- the way those are supported is clearer (as it is now directly visible
  in the generated sample files)
- if a future commit impacts this part of the generation it will be easier
  to assess that impact
@wing328 wing328 merged commit 6c0e727 into OpenAPITools:master May 16, 2025
27 checks passed
@wing328 wing328 added this to the 7.14.0 milestone Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants