[php-symfony] fix handling of endpoints with "text/plain" or "image/png" response type #21261
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This is the update of #21258 that I pushed too soon the other day. This time I took more time to thoroughly think it before opening this PR)
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)This fixes #21256 (and this subsequently fixes #13334, which is a subset of the other one).
This PR implements the 3 fixes that are required to be able to handle all the endpoints described in this OpenApi specification:
Namely this:
Controller.getOutputFormatreturns a valid format when the user accepts*/*(or when they don't specify any Accept header)->serialize($data, ...)`` when the 2nd argument isnull` (it would crash (error 500)). Instead it uses a straightforward way to handle the serialization in those simple casestext/plain(nb: to make it easier to review I did a separate commit for each of those 3 fixes)
Ping technical committed, ie: @jebentier @dkarlovi @mandrean @jfastnacht @ybelenko @renepardon (and thanks for your work!)