Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kotlin] Enum should match spec #17387

Closed
wants to merge 4 commits into from
Closed

Conversation

jarin
Copy link
Contributor

@jarin jarin commented Dec 13, 2023

Fixing the merge conflicts on #16333

  • [kotlin] Enum should match spec
  • [kotlin] export docs generators for enum change
  • [kotlin] export docs generators for enum change
  • fix conflicts

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented Dec 22, 2023

based on #16333

@wing328
Copy link
Member

wing328 commented Jan 11, 2024

can you please fix the merge conflicts when you've time?

@wing328 wing328 changed the title issue/3804 fix merge conflicts [kotlin] Enum should match spec Jan 11, 2024
@wing328 wing328 added this to the 7.3.0 milestone Jan 11, 2024
@jarin
Copy link
Contributor Author

jarin commented Jan 18, 2024

@wing328 There, methinks?

@jarin jarin marked this pull request as ready for review January 18, 2024 08:47
snowe2010 and others added 4 commits February 1, 2024 13:15
Adjust the enum generation to match what is in the spec, rather than
camel-casing it.
Add tests for capitalization scenarios, including for kotlin keywords
@wing328
Copy link
Member

wing328 commented Mar 9, 2024

closed via #18062

@wing328 wing328 closed this Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants