-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kotlin] Enum should match spec #16333
Conversation
Adjust the enum generation to match what is in the spec, rather than camel-casing it. Add tests for capitalization scenarios, including for kotlin keywords
Still awesome, but should've checked before opening my mouth, this is for Kotlin ofc 🙈 |
@snowe2010 thanks for the PR. Can you please PM me via Slack for a few questions on this PR when you've time? https://join.slack.com/t/openapi-generator/shared_invite/zt-12jxxd7p2-XUeQM~4pzsU9x~eGLQqX2g |
can you please resolve the merge conflicts when you've time? then we will merge it. thanks again for the PR. |
@wing328 sorry for the delay, I got sick for a long time and then have been quite busy. Merge conflicts have been resolved. Also, I lost our conversation in slack as it's been over 90 days, so I don't remember what else you had asked me to change. |
Hi, We have same problem. When will 7.4.0 be released? |
closed via #18062 |
closes #3804
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(6.3.0) (minor release - breaking changes with fallbacks),7.0.x
(breaking changes without fallbacks)I cannot find a 7... branch
@jimschubert
@dr4ke616
@karismann
@Zomzog
@andrewemery
@4brunu
@yutaka0m
@stefankoppier