Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kotlin] Enum should match spec #16333

Closed
wants to merge 6 commits into from

Conversation

snowe2010
Copy link
Contributor

@snowe2010 snowe2010 commented Aug 15, 2023

  • Adjust the enum generation to match what is in the spec, rather than camel-casing it.
  • Regenerate docs

closes #3804

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
    I cannot find a 7... branch
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@jimschubert
@dr4ke616
@karismann
@Zomzog
@andrewemery
@4brunu
@yutaka0m
@stefankoppier

Adjust the enum generation to match what is in the spec, rather than
camel-casing it.
Add tests for capitalization scenarios, including for kotlin keywords
@tuxmachine
Copy link
Contributor

tuxmachine commented Aug 16, 2023

Awesome! I hope to have some time next week, I'll test this in a project that's encountering this error. It's using the typescript-fetch generator currently.

Still awesome, but should've checked before opening my mouth, this is for Kotlin ofc 🙈

@wing328
Copy link
Member

wing328 commented Sep 5, 2023

@snowe2010 thanks for the PR. Can you please PM me via Slack for a few questions on this PR when you've time?

https://join.slack.com/t/openapi-generator/shared_invite/zt-12jxxd7p2-XUeQM~4pzsU9x~eGLQqX2g

@wing328
Copy link
Member

wing328 commented Oct 1, 2023

can you please resolve the merge conflicts when you've time?

then we will merge it. thanks again for the PR.

@snowe2010
Copy link
Contributor Author

@wing328 sorry for the delay, I got sick for a long time and then have been quite busy. Merge conflicts have been resolved. Also, I lost our conversation in slack as it's been over 90 days, so I don't remember what else you had asked me to change.

@wing328 wing328 mentioned this pull request Dec 22, 2023
5 tasks
@wing328 wing328 modified the milestones: 7.2.0, 7.3.0 Dec 22, 2023
@wing328 wing328 modified the milestones: 7.3.0, 7.4.0 Feb 8, 2024
@gimbimloki
Copy link
Contributor

gimbimloki commented Mar 4, 2024

Hi, We have same problem. When will 7.4.0 be released?

@wing328 wing328 mentioned this pull request Mar 9, 2024
5 tasks
@wing328
Copy link
Member

wing328 commented Mar 9, 2024

closed via #18062

@wing328 wing328 closed this Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [Kotlin] Enums are generated with odd capitalization
4 participants