Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile (cli, online) to use eclipse-temurin:17.0.3_7-jre-focal #17139

Merged
merged 7 commits into from
Nov 23, 2023

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Nov 19, 2023

Update Dockerfile (cli, online) to use eclipse-temurin:17.0.3_7-jre-focal
Add tests for openapi-generator-cli Dockerfile

FYI @OpenAPITools/generator-core-team

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328 wing328 added this to the 7.2.0 milestone Nov 19, 2023
@wing328 wing328 changed the title Add tests for openapi-generator-cli Dockerfile Update Dockerfile (cli, online) to use eclipse-temurin:17.0.3_7-jre-focal Nov 19, 2023
@wing328 wing328 mentioned this pull request Nov 19, 2023
5 tasks
@daveset
Copy link

daveset commented Nov 21, 2023

Thanks for addressing this and adding the test.

There is a high-rated openssl library CVE present in eclipse-temurin:17.0.3_3-jre-focal. Consider updating the image to eclipse-temurin:17.0.9_9-jre-focal which has addressed this CVE.

@wing328
Copy link
Member Author

wing328 commented Nov 21, 2023

@daveset done. thanks for the suggestion.

@wing328 wing328 merged commit aaed846 into master Nov 23, 2023
20 checks passed
@wing328 wing328 deleted the docker-image branch November 23, 2023 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants