-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use JDK17 images in Dockerfile #17076
Conversation
Did a push to |
@wing328 this switch to an Alpine-based image is failing to find bash:
It needs I'll add that if there are downstream projects that use |
thanks for pointing it out. just reverted the change. i'll file another one and include a test to catch the issue moving forward. |
* use jdk17 images in Dockerfile * use amazoncorretto:17.0.8-alpine3.18
Use amazoncorretto:17.0.8-alpine3.18 which has 0 vulnerabilities.
a follow-up PR to #17007
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming 7.1.0 minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)