Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cpp-qt] use ctest, fix warnings #14968

Merged
merged 4 commits into from
Apr 7, 2023
Merged

Conversation

MartinDelille
Copy link
Contributor

  • [cpp-qt-client] Use ctest
  • [cpp-qt-client] Fix warning about deprecated count() method

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date.sh
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@ravinikam @stkrwork @etherealjoy @muttleyxd

@MartinDelille
Copy link
Contributor Author

I didn't manage to configure properly openssl for windows and created an issue here: jurplel/install-qt-action#177

@MartinDelille MartinDelille requested review from muttleyxd and removed request for jimschubert March 21, 2023 13:38
@MartinDelille
Copy link
Contributor Author

Hi @wing328! I wondered if you would have any feedback on the PR! Best!

@wing328
Copy link
Member

wing328 commented Apr 7, 2023

LGTM. Thanks for the PR.

@wing328 wing328 merged commit f40433d into OpenAPITools:master Apr 7, 2023
@wing328 wing328 added Client: C++ Enhancement: CI/Test Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. labels Apr 7, 2023
@wing328 wing328 added this to the 6.6.0 milestone Apr 7, 2023
@wing328 wing328 changed the title qt ctest [cpp-qt] use ctest, fix warnings Apr 7, 2023
@MartinDelille MartinDelille deleted the qt-ctest branch April 7, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client: C++ Enhancement: CI/Test Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants