Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tools in a matrix #177

Closed
MartinDelille opened this issue Mar 16, 2023 · 2 comments
Closed

Use tools in a matrix #177

MartinDelille opened this issue Mar 16, 2023 · 2 comments

Comments

@MartinDelille
Copy link

I'm trying to use tools in a matrix without success here: https://github.com/MartinDelille/openapi-generator/blob/f06491b24154332020ff0bc9ad78ce4eee3ac204/.github/workflows/samples-cpp-qt-client.yaml

Here is my github action:

name: Samples cpp qt client

on:
  push:
    branches:
      - 'samples/client/petstore/cpp-qt/**'
  pull_request:
    paths:
      - 'samples/client/petstore/cpp-qt/**'

env:
  GRADLE_VERSION: 6.9

jobs:
  build:
    name: Build cpp qt client
    strategy:
      matrix:
        qt-version:
          - '5.15.2'
          - '6.4.2'
        os:
          - ubuntu-latest
          - macOS-latest
          - windows-latest
        include:
          - os: windows-latest
            tools: 'tools_openssl_x64'
    runs-on: ${{ matrix.os }}
    steps:
      - uses: actions/checkout@v3
      - uses: jurplel/install-qt-action@v3
        with:
          version: ${{ matrix.qt-version }}
          tools: ${{ matrix.tools }}
      - name: Build
        working-directory: "samples/client/petstore/cpp-qt"
        run: cmake . && cmake --build .

The tools: ${{ matrix.tools }} doesn't seems to have any effect. Am I doing something wrong ?

@ddalcino
Copy link
Contributor

From CI run: https://github.com/OpenAPITools/openapi-generator/actions/runs/4435878285/jobs/7783600205?pr=14968 in the "Run jurplel/install-qt-action/action@v3" step:

Arguments passed to the action:

Run jurplel/install-qt-action/action@v3
  with:
    version: 5.15.2
    target: desktop
    install-deps: true
    cache: false
    cache-key-prefix: install-qt-action
    tools: tools_openssl_x64
    set-env: true
    tools-only: false
    aqtversion: ==2.1.*
    py7zrversion: ==0.19.*

Relevant output for the install-tool part: https://github.com/OpenAPITools/openapi-generator/actions/runs/4435878285/jobs/7783600205?pr=14968#step:3:212

C:\hostedtoolcache\windows\Python\3.11.2\x64\python.exe -m aqt install-tool windows desktop tools_openssl_x64 --outputdir D:\a\openapi-generator/Qt
aqtinstall(aqt) v2.1.0 on Python 3.11.2 [CPython MSC v.1934 64 bit (AMD64)]
Downloading qt.tools.openssl.win_x64...
Redirected: qt.mirror.constant.com
Finished installation of openssl_1.1.1q_prebuild_x64.7z in 4.58491100
Finished installation
Time elapsed: 8.53421840 second

To me, it definitely looks like tools: ${{ matrix.tools }} had an effect. If you look, you will see a bunch of .dlls, .pdbs, and an openssl.exe at D:\a\openapi-generator\Qt\Tools\OpenSSL\Win_x64\bin.

If something has gone wrong in your CI run, I don't see what it has to do with install-qt-action.

@MartinDelille
Copy link
Author

Indeed. The issue came from the CMakeLists.txt so I fixed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants