Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dart][dart-dio] Bump Dio to 5.0.0 #14675

Merged
merged 8 commits into from
Feb 15, 2023

Conversation

kuhnroyal
Copy link
Contributor

@kuhnroyal kuhnroyal commented Feb 12, 2023

This PR updates the dart-dio generator to use dio: ^5.0.0.

Closes #14281

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date.sh
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

CC @jaumard (2018/09) @josh-burton (2019/12) @amondnet (2019/12) @sbu-WBT (2020/12) @kuhnroyal (2020/12) @agilob (2020/12) @ahmednfwela (2021/08)

Copy link
Contributor

@ahmednfwela ahmednfwela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, there is just a small typo

@asaarnak
Copy link

diox got ownership of dio github and migrated to dio: 5.0.0

@ahmednfwela
Copy link
Contributor

that's great news, then we can just replace all Diox strings in this PR to just Dio5 and change the dio_import back to normal dio

@kuhnroyal
Copy link
Contributor Author

that's great news, then we can just replace all Diox strings in this PR to just Dio5 and change the dio_import back to normal dio

We depend on lomsa-dev/http-mock-adapter#140 since we have tests using this package.

@kuhnroyal kuhnroyal changed the title [dart][dart-dio] Add diox generator option & sample [dart][dart-dio] Bump Dio to 5.0.0 Feb 13, 2023
@@ -27,8 +27,8 @@ class Openapi {
this.dio = dio ??
Dio(BaseOptions(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now dio 5.0 will not imply the default content type, please ensure it's valid in requests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think thats enough for now.

@kuhnroyal
Copy link
Contributor Author

@kuhnroyal
Copy link
Contributor Author

This is ready I think, the Git test dependency can be switched to a released version later, it is pinned to a commit.

@wing328 wing328 added this to the 6.4.0 milestone Feb 15, 2023
@wing328 wing328 merged commit 1814a04 into OpenAPITools:master Feb 15, 2023
@kuhnroyal kuhnroyal deleted the dart-dio/fix-imports branch February 15, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[dart-dio] Support DioX
7 participants