Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dart-dio] Support DioX #14281

Closed
josh-burton opened this issue Dec 18, 2022 · 8 comments · Fixed by #14675
Closed

[dart-dio] Support DioX #14281

josh-burton opened this issue Dec 18, 2022 · 8 comments · Fixed by #14675

Comments

@josh-burton
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Dio has been forked by another group of Flutter developers, with the intention of more active development and maintenance.

cfug/dio#1607

An option to generate a DioX Client, or perhaps migrating entirely to DioX would be great.

@kuhnroyal

@kuhnroyal
Copy link
Contributor

Yeah, I am one of those maintainers :) I will give it 2 weeks or so to see how it goes before doing anything. Also still looking for a way to wire the diox adapter into Dio. Not sure if that is possible yet.

@AlexV525
Copy link

For the first 6 months, you can use diox as a dio's fork by using dependency_overrides, see the README,

@kuhnroyal
Copy link
Contributor

Yea but I don't think we should generate a pubspec with a dependency_override.
I think it will have to be a generator option wich in theory should only affect imports for the moment.

@josh-burton
Copy link
Contributor Author

I did a quick proof of concept replacing the dio import, and it seems there are breaking changes with diox. Things like DioOptions timeout durations have changed type.

@ahmednfwela
Copy link
Contributor

@josh-burton if it's behind an opt-in flag it shouldn't be a problem that it will have breaking changes

@joshburton-assetowl
Copy link

well the output doesn't compile, so additional customisations would be required.

@AlexV525
Copy link

This can be converted to support the latest dio.

@kuhnroyal
Copy link
Contributor

Yes, will do that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants