Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Typescript] Enums generation (7.0.0) #14663

Merged
merged 3 commits into from
Feb 19, 2023
Merged

[Typescript] Enums generation (7.0.0) #14663

merged 3 commits into from
Feb 19, 2023

Conversation

ksvirkou-hubspot
Copy link
Contributor

@ksvirkou-hubspot ksvirkou-hubspot commented Feb 10, 2023

Issue

#14569

###Related PR

#14579

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date.sh
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@ksvirkou-hubspot ksvirkou-hubspot changed the title [Typescript] Enums generation [Typescript] Enums generation (7.0.0) Feb 10, 2023
@ksvirkou-hubspot
Copy link
Contributor Author

Copy link
Contributor

@TiFu TiFu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

CircleCi unrelated (pytests failing)

@TiFu TiFu merged commit fb18e7a into OpenAPITools:7.0.x Feb 19, 2023
@ksvirkou-hubspot ksvirkou-hubspot deleted the feature/typescriptEnumV7 branch March 21, 2023 10:50
@wing328 wing328 added this to the 6.5.0 milestone Apr 1, 2023
@wing328
Copy link
Member

wing328 commented Apr 12, 2023

@ksvirkou-hubspot I've merged the latest master into 7.0.x branch and resolved some merge conflicts.

Can you please pull the latest and review to ensure the typescriptclientcodegen.java is still good?

cc @lwj5 as his PR (#15096) is related

@ksvirkou-hubspot
Copy link
Contributor Author

@ksvirkou-hubspot I've merged the latest master into 7.0.x branch and resolved some merge conflicts.

Can you please pull the latest and review to ensure the typescriptclientcodegen.java is still good?

cc @lwj5 as his PR (#15096) is related

I've just done it. Looks good.

@bodograumann bodograumann mentioned this pull request May 3, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants