-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Typescript] Enums generation #14579
[Typescript] Enums generation #14579
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Would this be a breaking change?
Before assignments like let enumVar: Enum = "C"
worked. Does this still work now?
If it doesn't, I would consider this a breaking change which to my understanding should be filed against 7.0.x.
@ts Committee: Any opinions on this?
I'm not sure why we need to cast the enum options to With the |
|
If it's a braking change anyways, then I don't think we need to include the |
I've just removed |
@ksvirkou-hubspot : We should change the target branch to 7.0. Also, I'm not sure if in certain cases the old handling would be preferred (generating a type instead of an enum) - and if we should have a setting to allow for the (old) handling as well. Maybe someone else from the @ts Committee has an opinion on this? Other than that, the PR looks goot to me. |
Do you mean 7.0.x branch? |
I've just created PR but I can build it and generate samples.
|
Not sure tbh. |
Have you checked it by any chance? |
Done & merged #14663. Thank you @ksvirkou-hubspot for your contribution! |
#14569
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(6.3.0) (minor release - breaking changes with fallbacks),7.0.x
(breaking changes without fallbacks)