Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[swift5][client] improve headers order #14636

Merged
merged 1 commit into from
Mar 5, 2023

Conversation

4brunu
Copy link
Contributor

@4brunu 4brunu commented Feb 6, 2023

Since #7527 got merged, the global headers always override the local headers. This means that if there is a local header that you want to customise in some requests, and you also have a global request, the global request will always prevail.
This is somehow limiting, so with this PR, the local headers set in the request override the global headers.

@lightman73 @FranzMarini does this looks good to you?

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date.sh
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@jgavris (2017/07) @ehyche (2017/08) @Edubits (2017/09) @jaz-ah (2017/09) @4brunu (2019/11)

@4brunu 4brunu closed this Feb 7, 2023
@4brunu 4brunu reopened this Feb 7, 2023
@4brunu 4brunu merged commit 4bb8372 into OpenAPITools:7.0.x Mar 5, 2023
@4brunu 4brunu deleted the feature/swift-headers-order branch March 5, 2023 11:33
@wing328 wing328 added this to the 6.5.0 milestone Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants