Skip to content

Commit

Permalink
[swift5][client] improve headers order (#14636)
Browse files Browse the repository at this point in the history
  • Loading branch information
4brunu committed Mar 5, 2023
1 parent 1beec7e commit 4bb8372
Show file tree
Hide file tree
Showing 15 changed files with 30 additions and 90 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,6 @@ private var credentialStore = SynchronizedDictionary<Int, URLCredential>()

originalRequest.httpMethod = method.rawValue

headers.forEach { key, value in
originalRequest.setValue(value, forHTTPHeaderField: key)
}

buildHeaders().forEach { key, value in
originalRequest.setValue(value, forHTTPHeaderField: key)
}
Expand Down Expand Up @@ -218,10 +214,10 @@ private var credentialStore = SynchronizedDictionary<Int, URLCredential>()

{{#nonPublicApi}}internal{{/nonPublicApi}}{{^nonPublicApi}}open{{/nonPublicApi}} func buildHeaders() -> [String: String] {
var httpHeaders: [String: String] = [:]
for (key, value) in headers {
for (key, value) in {{projectName}}API.customHeaders {
httpHeaders[key] = value
}
for (key, value) in {{projectName}}API.customHeaders {
for (key, value) in headers {
httpHeaders[key] = value
}
return httpHeaders
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,6 @@ open class URLSessionRequestBuilder<T>: RequestBuilder<T> {

originalRequest.httpMethod = method.rawValue

headers.forEach { key, value in
originalRequest.setValue(value, forHTTPHeaderField: key)
}

buildHeaders().forEach { key, value in
originalRequest.setValue(value, forHTTPHeaderField: key)
}
Expand Down Expand Up @@ -218,10 +214,10 @@ open class URLSessionRequestBuilder<T>: RequestBuilder<T> {

open func buildHeaders() -> [String: String] {
var httpHeaders: [String: String] = [:]
for (key, value) in headers {
for (key, value) in PetstoreClientAPI.customHeaders {
httpHeaders[key] = value
}
for (key, value) in PetstoreClientAPI.customHeaders {
for (key, value) in headers {
httpHeaders[key] = value
}
return httpHeaders
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,6 @@ open class URLSessionRequestBuilder<T>: RequestBuilder<T> {

originalRequest.httpMethod = method.rawValue

headers.forEach { key, value in
originalRequest.setValue(value, forHTTPHeaderField: key)
}

buildHeaders().forEach { key, value in
originalRequest.setValue(value, forHTTPHeaderField: key)
}
Expand Down Expand Up @@ -218,10 +214,10 @@ open class URLSessionRequestBuilder<T>: RequestBuilder<T> {

open func buildHeaders() -> [String: String] {
var httpHeaders: [String: String] = [:]
for (key, value) in headers {
for (key, value) in PetstoreClientAPI.customHeaders {
httpHeaders[key] = value
}
for (key, value) in PetstoreClientAPI.customHeaders {
for (key, value) in headers {
httpHeaders[key] = value
}
return httpHeaders
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,6 @@ open class URLSessionRequestBuilder<T>: RequestBuilder<T> {

originalRequest.httpMethod = method.rawValue

headers.forEach { key, value in
originalRequest.setValue(value, forHTTPHeaderField: key)
}

buildHeaders().forEach { key, value in
originalRequest.setValue(value, forHTTPHeaderField: key)
}
Expand Down Expand Up @@ -218,10 +214,10 @@ open class URLSessionRequestBuilder<T>: RequestBuilder<T> {

open func buildHeaders() -> [String: String] {
var httpHeaders: [String: String] = [:]
for (key, value) in headers {
for (key, value) in PetstoreClientAPI.customHeaders {
httpHeaders[key] = value
}
for (key, value) in PetstoreClientAPI.customHeaders {
for (key, value) in headers {
httpHeaders[key] = value
}
return httpHeaders
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,6 @@ open class URLSessionRequestBuilder<T>: RequestBuilder<T> {

originalRequest.httpMethod = method.rawValue

headers.forEach { key, value in
originalRequest.setValue(value, forHTTPHeaderField: key)
}

buildHeaders().forEach { key, value in
originalRequest.setValue(value, forHTTPHeaderField: key)
}
Expand Down Expand Up @@ -218,10 +214,10 @@ open class URLSessionRequestBuilder<T>: RequestBuilder<T> {

open func buildHeaders() -> [String: String] {
var httpHeaders: [String: String] = [:]
for (key, value) in headers {
for (key, value) in PetstoreClientAPI.customHeaders {
httpHeaders[key] = value
}
for (key, value) in PetstoreClientAPI.customHeaders {
for (key, value) in headers {
httpHeaders[key] = value
}
return httpHeaders
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,6 @@ open class URLSessionRequestBuilder<T>: RequestBuilder<T> {

originalRequest.httpMethod = method.rawValue

headers.forEach { key, value in
originalRequest.setValue(value, forHTTPHeaderField: key)
}

buildHeaders().forEach { key, value in
originalRequest.setValue(value, forHTTPHeaderField: key)
}
Expand Down Expand Up @@ -218,10 +214,10 @@ open class URLSessionRequestBuilder<T>: RequestBuilder<T> {

open func buildHeaders() -> [String: String] {
var httpHeaders: [String: String] = [:]
for (key, value) in headers {
for (key, value) in PetstoreClientAPI.customHeaders {
httpHeaders[key] = value
}
for (key, value) in PetstoreClientAPI.customHeaders {
for (key, value) in headers {
httpHeaders[key] = value
}
return httpHeaders
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,6 @@ internal class URLSessionRequestBuilder<T>: RequestBuilder<T> {

originalRequest.httpMethod = method.rawValue

headers.forEach { key, value in
originalRequest.setValue(value, forHTTPHeaderField: key)
}

buildHeaders().forEach { key, value in
originalRequest.setValue(value, forHTTPHeaderField: key)
}
Expand Down Expand Up @@ -218,10 +214,10 @@ internal class URLSessionRequestBuilder<T>: RequestBuilder<T> {

internal func buildHeaders() -> [String: String] {
var httpHeaders: [String: String] = [:]
for (key, value) in headers {
for (key, value) in PetstoreClientAPI.customHeaders {
httpHeaders[key] = value
}
for (key, value) in PetstoreClientAPI.customHeaders {
for (key, value) in headers {
httpHeaders[key] = value
}
return httpHeaders
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,6 @@ open class URLSessionRequestBuilder<T>: RequestBuilder<T> {

originalRequest.httpMethod = method.rawValue

headers.forEach { key, value in
originalRequest.setValue(value, forHTTPHeaderField: key)
}

buildHeaders().forEach { key, value in
originalRequest.setValue(value, forHTTPHeaderField: key)
}
Expand Down Expand Up @@ -218,10 +214,10 @@ open class URLSessionRequestBuilder<T>: RequestBuilder<T> {

open func buildHeaders() -> [String: String] {
var httpHeaders: [String: String] = [:]
for (key, value) in headers {
for (key, value) in PetstoreClientAPI.customHeaders {
httpHeaders[key] = value
}
for (key, value) in PetstoreClientAPI.customHeaders {
for (key, value) in headers {
httpHeaders[key] = value
}
return httpHeaders
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,6 @@ open class URLSessionRequestBuilder<T>: RequestBuilder<T> {

originalRequest.httpMethod = method.rawValue

headers.forEach { key, value in
originalRequest.setValue(value, forHTTPHeaderField: key)
}

buildHeaders().forEach { key, value in
originalRequest.setValue(value, forHTTPHeaderField: key)
}
Expand Down Expand Up @@ -218,10 +214,10 @@ open class URLSessionRequestBuilder<T>: RequestBuilder<T> {

open func buildHeaders() -> [String: String] {
var httpHeaders: [String: String] = [:]
for (key, value) in headers {
for (key, value) in PetstoreClientAPI.customHeaders {
httpHeaders[key] = value
}
for (key, value) in PetstoreClientAPI.customHeaders {
for (key, value) in headers {
httpHeaders[key] = value
}
return httpHeaders
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,6 @@ open class URLSessionRequestBuilder<T>: RequestBuilder<T> {

originalRequest.httpMethod = method.rawValue

headers.forEach { key, value in
originalRequest.setValue(value, forHTTPHeaderField: key)
}

buildHeaders().forEach { key, value in
originalRequest.setValue(value, forHTTPHeaderField: key)
}
Expand Down Expand Up @@ -218,10 +214,10 @@ open class URLSessionRequestBuilder<T>: RequestBuilder<T> {

open func buildHeaders() -> [String: String] {
var httpHeaders: [String: String] = [:]
for (key, value) in headers {
for (key, value) in PetstoreClientAPI.customHeaders {
httpHeaders[key] = value
}
for (key, value) in PetstoreClientAPI.customHeaders {
for (key, value) in headers {
httpHeaders[key] = value
}
return httpHeaders
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,6 @@ open class URLSessionRequestBuilder<T>: RequestBuilder<T> {

originalRequest.httpMethod = method.rawValue

headers.forEach { key, value in
originalRequest.setValue(value, forHTTPHeaderField: key)
}

buildHeaders().forEach { key, value in
originalRequest.setValue(value, forHTTPHeaderField: key)
}
Expand Down Expand Up @@ -218,10 +214,10 @@ open class URLSessionRequestBuilder<T>: RequestBuilder<T> {

open func buildHeaders() -> [String: String] {
var httpHeaders: [String: String] = [:]
for (key, value) in headers {
for (key, value) in PetstoreClientAPI.customHeaders {
httpHeaders[key] = value
}
for (key, value) in PetstoreClientAPI.customHeaders {
for (key, value) in headers {
httpHeaders[key] = value
}
return httpHeaders
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,6 @@ open class URLSessionRequestBuilder<T>: RequestBuilder<T> {

originalRequest.httpMethod = method.rawValue

headers.forEach { key, value in
originalRequest.setValue(value, forHTTPHeaderField: key)
}

buildHeaders().forEach { key, value in
originalRequest.setValue(value, forHTTPHeaderField: key)
}
Expand Down Expand Up @@ -218,10 +214,10 @@ open class URLSessionRequestBuilder<T>: RequestBuilder<T> {

open func buildHeaders() -> [String: String] {
var httpHeaders: [String: String] = [:]
for (key, value) in headers {
for (key, value) in PetstoreClientAPI.customHeaders {
httpHeaders[key] = value
}
for (key, value) in PetstoreClientAPI.customHeaders {
for (key, value) in headers {
httpHeaders[key] = value
}
return httpHeaders
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,6 @@ open class URLSessionRequestBuilder<T>: RequestBuilder<T> {

originalRequest.httpMethod = method.rawValue

headers.forEach { key, value in
originalRequest.setValue(value, forHTTPHeaderField: key)
}

buildHeaders().forEach { key, value in
originalRequest.setValue(value, forHTTPHeaderField: key)
}
Expand Down Expand Up @@ -218,10 +214,10 @@ open class URLSessionRequestBuilder<T>: RequestBuilder<T> {

open func buildHeaders() -> [String: String] {
var httpHeaders: [String: String] = [:]
for (key, value) in headers {
for (key, value) in PetstoreClientAPI.customHeaders {
httpHeaders[key] = value
}
for (key, value) in PetstoreClientAPI.customHeaders {
for (key, value) in headers {
httpHeaders[key] = value
}
return httpHeaders
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,6 @@ open class URLSessionRequestBuilder<T>: RequestBuilder<T> {

originalRequest.httpMethod = method.rawValue

headers.forEach { key, value in
originalRequest.setValue(value, forHTTPHeaderField: key)
}

buildHeaders().forEach { key, value in
originalRequest.setValue(value, forHTTPHeaderField: key)
}
Expand Down Expand Up @@ -218,10 +214,10 @@ open class URLSessionRequestBuilder<T>: RequestBuilder<T> {

open func buildHeaders() -> [String: String] {
var httpHeaders: [String: String] = [:]
for (key, value) in headers {
for (key, value) in PetstoreClientAPI.customHeaders {
httpHeaders[key] = value
}
for (key, value) in PetstoreClientAPI.customHeaders {
for (key, value) in headers {
httpHeaders[key] = value
}
return httpHeaders
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,6 @@ open class URLSessionRequestBuilder<T>: RequestBuilder<T> {

originalRequest.httpMethod = method.rawValue

headers.forEach { key, value in
originalRequest.setValue(value, forHTTPHeaderField: key)
}

buildHeaders().forEach { key, value in
originalRequest.setValue(value, forHTTPHeaderField: key)
}
Expand Down Expand Up @@ -218,10 +214,10 @@ open class URLSessionRequestBuilder<T>: RequestBuilder<T> {

open func buildHeaders() -> [String: String] {
var httpHeaders: [String: String] = [:]
for (key, value) in headers {
for (key, value) in PetstoreClientAPI.customHeaders {
httpHeaders[key] = value
}
for (key, value) in PetstoreClientAPI.customHeaders {
for (key, value) in headers {
httpHeaders[key] = value
}
return httpHeaders
Expand Down

0 comments on commit 4bb8372

Please sign in to comment.