-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dart-dio] [dart] Unify both dart generators into just dart
#14346
[dart-dio] [dart] Unify both dart generators into just dart
#14346
Conversation
…to fix-non-legacy-discriminator-behavior
hideGenerationTimestamp: "true" | ||
enumUnknownDefaultCase: "true" | ||
serializationLibrary: "built_value" | ||
networkingLibrary: "dio" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about using library
(global option, not generator option) instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
currently the serializationLibrary
is assigned to library
global option (this was introduced in #9980)
I was going to make another PR that targets v7.0.0, with the correct parameters assigned, but I am not sure if this is the right approach
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…to dart-dio/optional-http-library
dart
Replaced by #15485 |
based on: #14291
Blocked on:
this PR adds support for using http library instead of dio
it's still WIP and highly experimental, suggestions welcome
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(6.3.0) (minor release - breaking changes with fallbacks),7.0.x
(breaking changes without fallbacks)