Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dart-dio] Fix non legacy discriminator behavior #14291

Merged

Conversation

ahmednfwela
Copy link
Contributor

@ahmednfwela ahmednfwela commented Dec 20, 2022

This is a QOL PR that solves point 5 of this issue #13372

Auto assign discriminator type on serialization based on current type

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@kuhnroyal @agilob @jaumard @josh-burton

@ahmednfwela ahmednfwela marked this pull request as ready for review December 20, 2022 08:37
@kuhnroyal
Copy link
Contributor

CI Failure unrelated

@wing328 wing328 merged commit da8d984 into OpenAPITools:master Jan 2, 2023
@ahmednfwela ahmednfwela deleted the fix-non-legacy-discriminator-behavior branch June 17, 2023 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants