Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes fromProperty when property is required vs optional #12858

Merged
merged 5 commits into from
Jul 14, 2022

Conversation

spacether
Copy link
Contributor

@spacether spacether commented Jul 13, 2022

Fixes fromProperty when property is required vs optional
The current code will grab a cached CodegenProperty whether or not the property is required in the higher object schema.
This messes up code that depends on property.required to be correct.
I preserved the old fromProperty method to make this a non-breaking change.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.1.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@spacether spacether added this to the 6.1.0 milestone Jul 13, 2022
@spacether spacether added the java label Jul 13, 2022
@spacether spacether merged commit c44fe8a into OpenAPITools:master Jul 14, 2022
@spacether spacether deleted the feat_fixes_issue12857 branch July 14, 2022 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] codegenProperty retrieves wrong property if one is required and another is optional
1 participant