[BUG] codegenProperty retrieves wrong property if one is required and another is optional

[spacether]

Bug Report Checklist

• Have you provided a full/minimal spec to reproduce the issue?
• Have you validated the input using an OpenAPI validator (example)?
• Have you tested with the latest master to confirm the issue still exists?
• Have you searched for related issues/PRs?
• What's the actual output vs expected output?
• [Optional] Sponsorship to speed up the bug fix or feature request (example)

Description

codegenProperty retrieves wrong property if one is required and another is optional

openapi-generator version

OpenAPI declaration file content or url

openapi: 3.0.3
info:
  title: openapi 3.0.3 sample spec
  description: sample spec for testing openapi functionality, built from json schema
    tests for draft6
  version: 0.0.1
paths: {}
components:
  schemas:
    FooRequired:
      properties:
        foo: {}
      required:
      - foo
    FooOptional:
      properties:
        foo: {}

Generation Details

Any generator

Steps to reproduce

Generate code and see that
the required property is not correct in

• FooRequired.vars[0].required
• FooOptional.vars[0].required

This is happening because we store the required status (defined at a schema level higher) in the codegenProperty instance.

Related issues/PRs

This came up when working on
#12826
Where the property foo is optional in one place and required in another

Suggest a fix

Add the required boolean into fromProperty creation signature and cache call.