Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rollback curl_list_free keyword #11677

Merged
merged 1 commit into from
Feb 22, 2022

Conversation

minerba
Copy link
Contributor

@minerba minerba commented Feb 21, 2022

PR checklist

  • Read the contribution guidelines.

  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.

  • Run the following to build the project and update samples:
    `{{/isOAuth}}
    {{/authMethods}}
    {{/hasAuthMethods}}

      if(bodyParameters != NULL) {
          postData(handle, bodyParameters);
      }
    
      res = curl_easy_perform(handle);
    
      curl_slist_free_all(headers);   // curl_slist_freeList_all -> curl_slist_free_all
    
      free(targetUrl);
    
      if(res == CURLE_OK) {
          curl_easy_getinfo(handle, CURLINFO_RESPONSE_CODE, &apiClient->response_code);
      } ``
    

    ./mvnw clean package
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh

    Commit all changed files. 
    This is important, as CI jobs will verify _all_ generator outputs of your HEAD commit as it would merge with master. 
    These must match the expectations made by your contribution. 
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example `./bin/generate-samples.sh bin/configs/java*`. 
    For Windows users, please run the script in [Git BASH](https://gitforwindows.org/).
    
  • File the PR against the correct branch: master (5.3.0), 6.0.x

  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented Feb 21, 2022

@canadaduane thanks for the PR.

cc @zhemant (2018/11) @ityuhui (2019/12) @michelealbano (2020/03)

Copy link
Contributor

@ityuhui ityuhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants