Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some keywords conflict occurs with zebos #90

Closed
clearday4 opened this issue Oct 29, 2021 · 7 comments · Fixed by #109
Closed

some keywords conflict occurs with zebos #90

clearday4 opened this issue Oct 29, 2021 · 7 comments · Fixed by #109

Comments

@clearday4
Copy link

clearday4 commented Oct 29, 2021

If I link the libkubernetes and zebos together, some keywords conflict occurred.
list_create, list_free
could you change these keywords?

18:04:22,338 INFO  - //MW_LIB/KAS/obj/x86_K8.4/libkubernetes.a(list.c.o): In function `list_create':
18:04:22,338 INFO  - //MW_LIB/KAS/K8SCLIENT_C_3RD/kubernetes/src/list.c:26: multiple definition of `list_create'
18:04:22,338 INFO  - ../../platform/arch-x86_K/obj/lib.a(linklist.o)://NET_APP/ZEBOS/ZEBOS3RD/lib/linklist.c:21: first defined here
18:04:22,338 INFO  - //MW_LIB/KAS/obj/x86_K8.4/libkubernetes.a(list.c.o): In function `list_free':
18:04:22,338 INFO  - //MW_LIB/KAS/K8SCLIENT_C_3RD/kubernetes/src/list.c:92: multiple definition of `list_free'
18:04:22,338 INFO  - ../../platform/arch-x86_K/obj/lib.a(linklist.o)://NET_APP/ZEBOS/ZEBOS3RD/lib/linklist.c:48: first defined here
18:04:22,338 INFO  - collect2: error: ld returned 1 exit status
@ityuhui
Copy link
Member

ityuhui commented Oct 29, 2021

I want to resolve this problem before. OK. will put this issue to development backlog.
You can also submit a PR to the upstream project openapi-generatror https://github.com/ityuhui/openapi-generator/blob/master/modules/openapi-generator/src/main/resources/C-libcurl/list.h.mustache
Then we can merge the change back.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 27, 2022
@ityuhui
Copy link
Member

ityuhui commented Jan 30, 2022

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 30, 2022
@ityuhui
Copy link
Member

ityuhui commented Feb 22, 2022

@minerba

Since your PR ( OpenAPITools/openapi-generator#11190 and OpenAPITools/openapi-generator#11677) have already been committed, can you regenerate the c client to merge the change? The guide can be found at https://github.com/kubernetes-client/c/blob/master/docs/how-to-regenerate-the-c-client.md

@minerba
Copy link

minerba commented Feb 25, 2022

@ityuhui Ok, I will check

@ityuhui
Copy link
Member

ityuhui commented Mar 9, 2022

@minerba

I merge your code by the PR #109 because I want to fix a bug based on the latest code.
So you don't need re-generate the C client any more for this ticket.
Thanks !

@minerba
Copy link

minerba commented Mar 11, 2022

@ityuhui
Ok, Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants