-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spring hide controller impl #11611
Spring hide controller impl #11611
Conversation
…to temporarily preserve code.
Circle CI seems not related to PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change itself looks fine - just a question on direction of when the goal to remove the flag is
@@ -536,6 +536,8 @@ public void processOpts() { | |||
|
|||
additionalProperties.put("lambdaSplitString", new SplitStringLambda()); | |||
|
|||
// apiController: hide implementation behind undocumented flag to temporarily preserve code | |||
additionalProperties.put("_api_controller_impl_", false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reference - is there a discussion on when to remove this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left as a fallback in case there are issues with the spring-mvc removal. Could be removed at the latest with 7.0.0 if not needed.
Finish JDK7 removal from Java Spring generators
apiController.mustache: hide implementation behind undocumented flag (api_controller_impl) to temporarily preserve code.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(5.3.0),6.0.x