Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring hide controller impl #11611

Merged

Conversation

cachescrubber
Copy link
Contributor

@cachescrubber cachescrubber commented Feb 15, 2022

Finish JDK7 removal from Java Spring generators

apiController.mustache: hide implementation behind undocumented flag (api_controller_impl) to temporarily preserve code.

  • [x ] Read the contribution guidelines.
  • [x ] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [ x] Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • [ x] File the PR against the correct branch: master (5.3.0), 6.0.x
  • [ x] If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@cachescrubber
Copy link
Contributor Author

FYI @wing328 As discussed in #11561

@cachescrubber
Copy link
Contributor Author

Circle CI seems not related to PR.

Copy link
Contributor

@welshm welshm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change itself looks fine - just a question on direction of when the goal to remove the flag is

@@ -536,6 +536,8 @@ public void processOpts() {

additionalProperties.put("lambdaSplitString", new SplitStringLambda());

// apiController: hide implementation behind undocumented flag to temporarily preserve code
additionalProperties.put("_api_controller_impl_", false);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference - is there a discussion on when to remove this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left as a fallback in case there are issues with the spring-mvc removal. Could be removed at the latest with 7.0.0 if not needed.

@wing328 wing328 added this to the 6.0.0 milestone Feb 16, 2022
@wing328 wing328 merged commit 5afec1f into OpenAPITools:master Feb 16, 2022
@cachescrubber cachescrubber deleted the spring-hide-controller-impl branch February 16, 2022 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants