-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove JDK7 support from Java Spring generators #11561
Conversation
Some unit tests have to be adjusted. |
Yup, will fix those after merging your (and other) spring-related PRs. |
@wing328 Nor sure wether we should remove the implementation in apiController.mustache. Could make migration for spring-mvc users more straight forward - and could be a value for itself. WDYT? |
Added back via 63a469f Agreed with the direction to make the migration easier for |
Thx. I'll give more feedback and review throughout the day. |
The code won't compile as it's missing those JDK7 import. Shall we add those
|
Hmm, the missing imports are not jdk8 related IMO. They miss swagger.v3 and spring-web imports. We 'll need a flag to enable usage of the "impl-in-controller" pattern? Probably the switch has been implicit via the java8 toggle. |
I'll try to add those import
I suggest we go without the flag to start with. If later there's a demand for it, we can always add one. |
Done. CircleCI failure not related to this change. |
I think we still need to hide the code behind a flag. We should just not expose it via cli to make no commitment. As it is right now there is a code duplication between Api and Controller. Thanks for your patience anyway. Otherwise the PR looks good. The code was previously hidden behind the {{^jdk8}} test. You replaced it with {{^reactive}} which is not sufficient. |
OK. Let's go with what we've for now as I don't want to include too many changes in this PR. We can always add the option later. |
Remove JDK7 support from Java Spring generators (default to JDK8+ starting in v6.0.0)
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(5.3.0),6.0.x
cc @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10)