Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds generator default template engine #11366

Conversation

spacether
Copy link
Contributor

@spacether spacether commented Jan 21, 2022

Adds generator default template engine
Once this is merged, one will not need to pass in -e handlebars when running the python-experimental generator

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@spacether spacether marked this pull request as draft January 21, 2022 05:53
@spacether
Copy link
Contributor Author

spacether commented Jan 23, 2022

I was successfully able to generate samples by passing in the generatorName using -g and omitting it from the configuration file with these invocations.

python-experimental

java -jar ./modules/openapi-generator-cli/target/openapi-generator-cli.jar generate -g python-experimental -c bin/configs/python-experimental-nogeneratorName.yaml

python-flask

java -jar ./modules/openapi-generator-cli/target/openapi-generator-cli.jar generate -g python-flask -c bin/configs/python-flask-nogeneratorName.yaml

That verifies that #11276 will not re-occur when I release this

@spacether spacether added this to the 5.4.0 milestone Jan 23, 2022
@spacether spacether marked this pull request as ready for review January 23, 2022 22:15
@spacether spacether merged commit 78f4748 into OpenAPITools:master Jan 23, 2022
@spacether spacether deleted the feat_adds_generator_default_template_engine branch January 23, 2022 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant