Has generators set default template engine #11245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacether
changed the title
spacether
force-pushed
the
feat_fixes_python_exp_template_engine
branch
2 times, most recently
from
7fcd548
to
77d7b5b
Compare
|
LGTM 👍 |
spacether
added a commit
to spacether/openapi-generator
that referenced
this pull request
Jan 14, 2022
This reverts commit dd3bba8. Because it broke peoples builds per this issue OpenAPITools#11276
spacether
added a commit
that referenced
this pull request
Jan 14, 2022
spacether
added a commit
that referenced
this pull request
Jan 21, 2022
spacether
added a commit
to spacether/openapi-generator
that referenced
this pull request
Jan 21, 2022
…ols#11245)" (OpenAPITools#11316)" This reverts commit 5798742.
spacether
added a commit
that referenced
this pull request
Jan 23, 2022
* Revert "Revert "Has generators set default template engine (#11245)" (#11316)" This reverts commit 5798742. * Only loads in the default template engine if the config file contains the generatorName * Only sets templatingEngineName using condif default in one place * Adds config files that lack generatorName * Revert "Adds config files that lack generatorName" This reverts commit 7dafc93. * Adds generator default templating engine to the generator metadata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows generators to set defaultTemplateEngine
python-experimental needs to use handlebars as its default template engine
If we don't allow this then when devs use generator that need to use handlebars by default the devs must always pass in the -e or templatingEngineName yaml input; even though all the template files are handlebars files for python-experimental.
For context the python-experimental generator only works with handlebars templates.
That template engine allows any depth of indented partials and python-experimental uses it to render inline schemas.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(5.3.0),6.0.xCan I get a review core team?
@wing328 (2015/07) ❤️
@jimschubert (2016/05) ❤️
@cbornet (2016/05)
@ackintosh (2018/02) ❤️
@jmini (2018/04) ❤️
@etherealjoy (2019/06)
@spacether (2020/05) ❤️
cc @OpenAPITools/generator-core-team