Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avro schema generation fix for properties with type ref to an enum #11201

Merged
merged 1 commit into from
Jan 4, 2022

Conversation

aghajani
Copy link
Contributor

Changing the mustache template to generate correct type for properties with ref as enum.
Fixes #11200

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request. @sgadouar

@aghajani aghajani changed the title #11200 Avro schema generation fix for properties with type ref to an enum Avro schema generation fix for properties with type ref to an enum Dec 30, 2021
@wing328 wing328 added Issue: Bug Schema: Avro Generation of Avro schemas labels Dec 30, 2021
@wing328 wing328 added this to the 5.4.0 milestone Jan 2, 2022
@wing328
Copy link
Member

wing328 commented Jan 4, 2022

Tested locally and the fix looks good:

diff --git a/MoneyEvent.avsc b/MoneyEvent.avsc
index f232ca0..8681032 100644
--- a/MoneyEvent.avsc
+++ b/MoneyEvent.avsc
@@ -6,7 +6,7 @@
   "fields": [
     {
       "name": "eventType",
-      "type": ,
+      "type": "model.MoneyEventType",
       "doc": ""
     }
   ]

@wing328 wing328 merged commit a3b9018 into OpenAPITools:master Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Bug Schema: Avro Generation of Avro schemas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] empty type property on referenced enums
2 participants