Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] empty type property on referenced enums #11200

Closed
5 of 6 tasks
aghajani opened this issue Dec 30, 2021 · 0 comments · Fixed by #11201
Closed
5 of 6 tasks

[BUG] empty type property on referenced enums #11200

aghajani opened this issue Dec 30, 2021 · 0 comments · Fixed by #11201

Comments

@aghajani
Copy link
Contributor

Bug Report Checklist

  • Have you provided a full/minimal spec to reproduce the issue?
  • Have you validated the input using an OpenAPI validator (example)?
  • Have you tested with the latest master to confirm the issue still exists?
  • Have you searched for related issues/PRs?
  • What's the actual output vs expected output?
  • [Optional] Sponsorship to speed up the bug fix or feature request (example)
Description

When an enum is defined to be used later on multiple places using ref, the output Avro schema will put empty value on type property attribute of ref property. See samples below for better understanding.

openapi-generator version

lateset build from master and release: 5.3.1

OpenAPI declaration file content or url
openapi: 3.0.0
info:
  title: Money event schema
  description: |
    Specification for the the MoneyEvent and all subtypes
  version: 0.1.0
servers: []
paths: {}

components:
  schemas:
    MoneyEventType:
      description: 'The kind of monetary transaction'
      type: string
      enum:
        - x1
        - x2

    MoneyEvent:
      description: 'A event describing some kind of monetary transaction'
      required:
        - eventType
      properties:
        eventType:
          $ref: '#/components/schemas/MoneyEventType'
Generation Details

generating models is enough to see invalid output for MoneyEvent:

{
  "namespace": "models",
  "type": "record",
  "doc": "A event describing some kind of monetary transaction",
  "name": "MoneyEvent",
  "fields": [
    {
      "name": "eventType",
      "type": ,
      "doc": ""
    }
  ]
}
Suggest a fix

The fix should be as simple as changing the mustache template for typeProperty in avro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant