Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Returns Meta data of notification #98

Merged
merged 4 commits into from
Oct 28, 2016
Merged

Conversation

deepmehtait
Copy link
Contributor

@deepmehtait deepmehtait commented Oct 27, 2016

Meta data was always returning null in onNotificationOpened(message, data, isActive) {}
Looks like
screen shot 2016-10-27 at 11 22 37 am now one signal is sending empty stringify object {} in additionalData for Android & for iOS its in form of Object. In case of data
screen shot 2016-10-27 at 11 22 49 am.
Changed the way how additional data was being handled. first checking if additionalData: {} return null else convert string to object.

@jkasten2
Copy link
Member

@avishayil Can you merge this one in? It has already been well tested.

I'll make sure it gets included in our 2.0 pull request as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants