Skip to content

Commit

Permalink
Fix crash when no additional data is set
Browse files Browse the repository at this point in the history
  • Loading branch information
pettersamuelsen committed Oct 18, 2016
1 parent cd4d2e9 commit b89e023
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion index.js
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,8 @@ Notifications.idsAvailable = function(idsAvailable) {

DeviceEventEmitter.addListener(DEVICE_NOTIF_EVENT, function(notifData) {
var message = notifData.message;
var data = (notifData.additionalData !== null && typeof notifData.additionalData === 'object') ? notifData.additionalData : JSON.parse(notifData.additionalData);
var hasAdditionalData = notifData.additionalData !== null && typeof notifData.additionalData === 'object';

This comment has been minimized.

Copy link
@deepmehtait

deepmehtait Oct 27, 2016

Contributor

@pettersamuelsen : need add JSON.parse() in this like

var hasAdditionalData = notifData.additionalData !== null && typeof JSON.parse(notifData.additionalData) === 'object';
var data = hasAdditionalData ? JSON.parse(notifData.additionalData) : null;

else it data object field will always null on Android and iOS its Object so no JSON.parse() needed.
screen shot 2016-10-26 at 4 47 45 pm
#98

var data = hasAdditionalData ? notifData.additionalData : null;
var isActive = notifData.isActive;
Notifications._onNotificationOpened(message, data, isActive);
});
Expand Down

0 comments on commit b89e023

Please sign in to comment.