contract(OMN-10711): add OCC ticket contract for storage/vector config declaration by jonahgabriel · Pull Request #926 · OmniNode-ai/onex_change_control

jonahgabriel · 2026-05-11T15:01:58Z

Summary

Adds OCC contract and DoD receipts for OMN-10711: Declare storage/vector config in contract.yaml.

contracts/OMN-10711.yaml — ticket contract with dod_evidence
drift/dod_receipts/OMN-10711/dod-unit-tests/command.yaml — 2271 unit tests PASS receipt
drift/dod_receipts/OMN-10711/dod-occ-pr/command.yaml — self-binding OCC PR receipt

Companion PR: OmniNode-ai/omnimarket#599

Ticket

OMN-10711

Summary by CodeRabbit

Documentation
- Added internal contract definitions and compliance evidence records for system governance and tracking purposes.

…g declaration Adds env_dependencies sections to four omnimarket nodes that read storage/vector connection vars without contract.yaml declaration. Also fixes missing handler block in node_navigation_history_reducer. Contract declarations only — no Python code changed. dod_evidence: - dod-unit-tests: 2271 unit tests PASS - dod-occ-pr: this OCC PR

coderabbitai · 2026-05-11T15:02:13Z

Warning

Rate limit exceeded

@jonahgabriel has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 9 minutes and 32 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e509bb09-c323-4c83-bf29-ed96041e394a

📥 Commits

Reviewing files that changed from the base of the PR and between ecdc501 and cba4a5a.

📒 Files selected for processing (3)

contracts/OMN-10711.yaml
drift/dod_receipts/OMN-10711/dod-occ-pr/command.yaml
drift/dod_receipts/OMN-10711/dod-unit-tests/command.yaml

📝 Walkthrough

Walkthrough

This PR adds a contract declaration for ticket OMN-10711 that documents missing environment dependencies and handler block additions across omnimarket nodes. The declaration includes governance configuration and is supported by two command execution receipts verifying successful PR validation and unit test results.

Changes

OMN-10711 Contract Declaration

Layer / File(s)	Summary
Contract Declaration Header `contracts/OMN-10711.yaml` (lines 1–14)	Introduces contract metadata for OMN-10711 with schema version, ticket title, and summary describing env_dependencies sections and node_navigation_history_reducer handler block additions.
Governance Configuration `contracts/OMN-10711.yaml` (lines 15–18)	Emergency bypass disabled with empty justification and follow-up fields.
Command Evidence Receipts `drift/dod_receipts/OMN-10711/dod-occ-pr/command.yaml`, `drift/dod_receipts/OMN-10711/dod-unit-tests/command.yaml`	Two YAML receipts record proof-of-execution: GitHub PR check (`gh pr view`) returning OPEN status and pytest unit tests completing with PASS status, both timestamped and signed by omniclaude-ci runner.
DOD Evidence Verification Checks `contracts/OMN-10711.yaml` (lines 19–33)	Two generated receipt-check entries that grep the respective receipt YAMLs to verify PASS status and matching ticket_id.

🎯 2 (Simple) | ⏱️ ~8 minutes

🐰 A contract springs forth, with evidence in hand,
Two receipts prove the work—tests pass across the land!
No code changed, just declarations so clear,
Drifts documented and governance secured here. ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The pull request title clearly and specifically summarizes the main change: adding an OCC contract for ticket OMN-10711 to declare storage/vector configuration, which directly aligns with the changeset's primary focus on contract declarations and DoD evidence.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch jonah/omn-10711-storage-config-contract

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@drift/dod_receipts/OMN-10711/dod-occ-pr/command.yaml`:
- Line 9: Replace the placeholder value for the commit_sha field in command.yaml
with the actual Git commit SHA for the attested OCC commit (the real commit
referenced by this receipt); locate the commit_sha key in the file and set it to
the correct full commit SHA string (or the repository's accepted short SHA) that
matches the attested scope so the receipt records a valid commit instead of
"pending-occ-pr".

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e49fab4d-34fc-42b4-8ba5-2a98a7e78a55

📥 Commits

Reviewing files that changed from the base of the PR and between c9fa0c3 and ecdc501.

📒 Files selected for processing (3)

contracts/OMN-10711.yaml
drift/dod_receipts/OMN-10711/dod-occ-pr/command.yaml
drift/dod_receipts/OMN-10711/dod-unit-tests/command.yaml

…ing, correct check_values

… check_value to include PR number

…mniNode-ai#949 (OmniNode-ai#581) The OMN-9855 contract previously referenced PR OmniNode-ai#926 / commit b424155a89b298f85f04cd20016139b49d8877ed (a superseded attempt). The ticket actually merged via omnibase_core PR OmniNode-ai#949, merge commit 15e4162082be070c619fee901e859ee5a1120050 (mergedAt 2026-04-27T15:13:17Z). Updates evidence_requirements + dod_evidence check_values to point at PR OmniNode-ai#949 and the new merge commit SHA, and commits the live DoD receipt (3/3 verified) at evidence/OMN-9855/dod_report.json so the durable evidence trail in onex_change_control matches the Linear Done state. Receipt regenerated against the updated contract via: ONEX_EVIDENCE_ROOT=<worktree>/evidence \ python -m omnimarket.nodes.node_dod_verify \ --ticket-id OMN-9855 \ --contract-path <worktree>/contracts/OMN-9855.yaml Result: total=3 verified=3 failed=0 skipped=0. dod_evidence: - dod-001: gh pr diff 949 --name-only -> ci.yml + test_detect_test_paths.py - dod-002: +def test_schedule_event_escalates_to_full_suite() -> None: - dod-003: cron \"13 7 * * *\" present at ref 15e4162082be070c619fee901e859ee5a1120050

coderabbitai Bot reviewed May 11, 2026

View reviewed changes

Comment thread drift/dod_receipts/OMN-10711/dod-occ-pr/command.yaml Outdated

jonahgabriel added 2 commits May 11, 2026 11:12

fix(OMN-10711): fix receipt format — valid commit_sha, pr_number bind…

d826c5e

…ing, correct check_values

fix(OMN-10711): add OCC PR #926 self-binding receipt and fix contract…

cba4a5a

… check_value to include PR number

jonahgabriel enabled auto-merge (squash) May 11, 2026 19:24

jonahgabriel merged commit e63db19 into main May 11, 2026
28 checks passed

jonahgabriel deleted the jonah/omn-10711-storage-config-contract branch May 11, 2026 19:24

This was referenced May 26, 2026

evidence(OMN-12245): bind omnimarket PR 926 head #1738

Merged

evidence(OMN-12245): bind omnimarket PR 926 final head #1740

Merged

jonahgabriel mentioned this pull request Aug 18, 2026

evidence(OMN-15651): OCC companion for OmniNode-ai/omninode_infra#938 #6654

Merged

Navigation Menu

Repository navigation

contract(OMN-10711): add OCC ticket contract for storage/vector config declaration - #926

contract(OMN-10711): add OCC ticket contract for storage/vector config declaration#926
jonahgabriel merged 3 commits into
mainfrom
jonah/omn-10711-storage-config-contract

jonahgabriel commented May 11, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented May 11, 2026 •

edited

Loading

Rate limit exceeded

Walkthrough

Changes

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

jonahgabriel commented May 11, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Ticket

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented May 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rate limit exceeded

Walkthrough

Changes

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

jonahgabriel commented May 11, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented May 11, 2026 •

edited

Loading