Repository navigation
fix(OMN-10711): Declare storage/vector config in contract.yaml - #599
Conversation
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughFive contract YAML files are updated to declare missing environment dependencies and handler metadata. Work ticket OMN-10711 tracks additions of ChangesStorage/Vector Configuration Contract Declarations
Estimated Code Review Effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
✅ Architectural Review — PASSEDErrors: 0 What this checks
No architectural violations found. Powered by node_pr_review_bot |
✅ PR Review Bot — CLEANFindings: 0
Verdict semantics
Powered by node_pr_review_bot — Qwen3-Coder-30B reviewer + DeepSeek-R1 judge (OMN-7963) |
|
| Verdict | Meaning | Blocks merge? |
|---|---|---|
passed |
No critical/error findings | No |
blocked |
CRITICAL or ERROR findings found | Yes |
degraded |
All models unavailable (infra) | No (pilot) |
Powered by omniintelligence.review_pairing.cli_review — node-based adversarial review via HandlerLlmCliSubprocess (OMN-8524)
Add env_dependencies sections to four nodes that read storage/vector
connection vars without contract declaration:
- node_agent_coordinator_orchestrator: VALKEY_HOST
- node_baseline_capture: OMNIBASE_INFRA_DB_URL, POSTGRES_{HOST,PORT}, VALKEY_{HOST,PORT}, QDRANT_{HOST,PORT}
- node_navigation_history_reducer: QDRANT_{HOST,PORT}
- node_projection_llm_cost: POSTGRES_{HOST,PORT}
node_code_embedding_effect and node_code_enrichment_effect were already
covered by existing config: sections with env_var declarations.
…ract node_navigation_history_reducer was in KNOWN_MAIN_VIOLATIONS for missing handler block; touching the contract in this PR promotes it to strict validation, so the handler block must be added to pass node-drift-gate. Also adds docs/work-tracking/contracts/OMN-10711.yaml to satisfy the deploy-gate (dod-deploy evidence with docker exec check_value).
4560471 to
cb01aa0
Compare
1 participant
Summary
Declares storage/vector connection env vars in
contract.yamlfor four nodes that were reading them bare without contract registration:VALKEY_HOST(required at runtime by AdapterValkey)OMNIBASE_INFRA_DB_URL,POSTGRES_HOST,POSTGRES_PORT,VALKEY_HOST,VALKEY_PORT,QDRANT_HOST,QDRANT_PORT(all optional -- probes skip gracefully when unset)QDRANT_HOST,QDRANT_PORT(optional -- no-op when unset)POSTGRES_HOST,POSTGRES_PORT(optional -- fallback whenOMNIBASE_INFRA_DB_URLunset)node_code_embedding_effectandnode_code_enrichment_effectalready covered by existingconfig:sections withenv_varentries.Also adds missing
handler:block tonode_navigation_history_reducerto fix pre-existing node-drift-gate strict violation triggered by touching the file.No Python code changed -- contract declarations only.
Ticket
OMN-10711
Verification
uv run ruff format src/ && uv run ruff check src/-- passeduv run pytest tests/ -m unit-- 2271 passed, 0 failedOMNIBASE_INFRA_PATH=.../omnibase_infra pre-commit run --all-files-- all hooks passedEvidence-Source: OCC#926
Evidence-Ticket: OMN-10711