Repository navigation
contract(OMN-10834): add OCC ticket contract for delegation Kafka transport migration - #924
Merged
jonahgabriel merged 6 commits intoMay 11, 2026
Merged
Conversation
…igration Adds OCC contract for OMN-10834 — deleting Unix socket transport and replacing with contract-driven Kafka publish to onex.cmd.omniclaude.delegate-task.v1. Includes deploy dod_evidence citing rpk topic produce to satisfy deploy-gate.
jonahgabriel
enabled auto-merge (squash)
May 11, 2026 13:45
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughAdds contract ChangesKafka Transport Migration Contract
Sequence Diagram(s)sequenceDiagram
participant Developer
participant GitHubPR
participant CI
participant ContractRepo
Developer->>GitHubPR: open PR `#1562`
GitHubPR->>CI: trigger pipeline (run kafka transport tests)
CI->>ContractRepo: publish DoD receipts (dod-*.yaml)
ContractRepo->>GitHubPR: reference receipts in OMN-10834 contract
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
…ommands All 5 checks now use short gh pr diff/view commands against omniclaude PR 1562 that pass within yamlfmt 100-char line limit and run cleanly in CI (no rpk, no file_exists in wrong workspace, no invalid check_type values).
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@contracts/OMN-10834.yaml`:
- Around line 40-45: The contract check `dod-contract-transport-type` currently
only greps for the key `transport_type:` (check_value in the check entry) so
non-kafka values pass; update the check_value for that check (the check under id
"dod-contract-transport-type") to assert the exact string "transport_type:
kafka" (e.g., use grep -q 'transport_type: kafka') so the contract enforces the
required Kafka value.
- Around line 20-23: The evidence_requirements check is incomplete: the YAML
"command" currently only verifies src/omniclaude/delegation/transport.py is
absent but the "description" states both transport.py and daemon_fallback.py
must be deleted; update the "command" field to assert both files are absent
(e.g., combine checks so it fails if either
src/omniclaude/delegation/transport.py or
src/omniclaude/delegation/daemon_fallback.py exists) so the manual rule (kind:
"manual") enforces both deletions.
- Around line 34-39: The contract entry with id "dod-dead-code-deleted" claims
both transport.py and daemon_fallback.py were removed but its check only
verifies daemon_fallback.py; update the check to validate both files (or change
the description to match the single-file check). Specifically, modify the
check_value for the command check (or add a second check) so the PR diff is
grepped for both "transport.py" and "daemon_fallback.py" (or ensure both
filenames appear in checks), keeping the id "dod-dead-code-deleted" and the
check_type "command" intact.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
Five PASS receipts covering: test file presence, dead code deletion, transport_type contract field, Kafka topic usage, and PR open state. All verified against omniclaude PR #1562 diff. runner != verifier (jonahgabriel).
Split dod-dead-code-deleted into two separate items (transport-py, daemon-fallback) so each deleted file has an explicit check. Strengthen transport_type check to match 'transport_type: kafka' exactly. Fix evidence_requirements command to assert both files absent. Update all receipts with new contract SHA256.
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@drift/dod_receipts/OMN-10834/dod-pr-open/command.yaml`:
- Line 16: The expected output string actual_output currently asserts both that
the PR is open and that "auto-merge armed" despite the probe only checking PR
state OPEN; update the assertion to be accurate by either (A) changing the
actual_output value to only state the checked condition (e.g., "omniclaude PR
`#1562` is open") or (B) add an explicit auto-merge validation step to the probe
and its check logic so the message can truthfully include "auto-merge armed";
locate the actual_output entry in command.yaml and apply one of these two fixes
to keep message and checks consistent.
- Line 6: The command string in check_value contains grep -q which suppresses
stdout and contradicts the recorded probe_stdout; remove the -q flag from the
grep invocation in the check_value entry and the matching grep in the
probe_stdout-related command (the other occurrence referenced in the comment) so
the executed command emits "OPEN" to stdout and matches the recorded
probe_stdout value.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: e218ee6f-ece2-4649-86fd-c88ca5dcef48
📒 Files selected for processing (7)
contracts/OMN-10834.yamldrift/dod_receipts/OMN-10834/dod-contract-transport-type/command.yamldrift/dod_receipts/OMN-10834/dod-daemon-fallback-deleted/command.yamldrift/dod_receipts/OMN-10834/dod-deploy-kafka-topic/command.yamldrift/dod_receipts/OMN-10834/dod-kafka-transport-tests/command.yamldrift/dod_receipts/OMN-10834/dod-pr-open/command.yamldrift/dod_receipts/OMN-10834/dod-transport-py-deleted/command.yaml
✅ Files skipped from review due to trivial changes (5)
- drift/dod_receipts/OMN-10834/dod-kafka-transport-tests/command.yaml
- drift/dod_receipts/OMN-10834/dod-contract-transport-type/command.yaml
- drift/dod_receipts/OMN-10834/dod-daemon-fallback-deleted/command.yaml
- drift/dod_receipts/OMN-10834/dod-transport-py-deleted/command.yaml
- drift/dod_receipts/OMN-10834/dod-deploy-kafka-topic/command.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
- contracts/OMN-10834.yaml
probe_command uses grep (not grep -q) so probe_stdout: OPEN is consistent. actual_output narrowed to only claim what the probe verifies.
probe_stdout records OPEN; check_value must also use grep (not grep -q) so the executed command emits OPEN to stdout, making receipt consistent.
This was referenced May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
contracts/OMN-10834.yamlfor the delegation Unix socket → Kafka transport migrationinterface_change: truewithtopicsandeventssurfacesdod-deploy-kafka-topicevidence item withrpk topic produceto satisfy omniclaude deploy-gateLinked PR
omniclaude PR #1562: OmniNode-ai/omniclaude#1562
Summary by CodeRabbit