Repository navigation
fix(OMN-10734): correct receipt binding — pr_number=1552, commit_sha=OCC SHA - #874
Merged
Merged
Conversation
Sets pr_number=1552 (omniclaude PR) and commit_sha to the omniclaude commit SHA so the eligibility validator can bind the receipts to the omniclaude PR being reviewed. Previous OCC PR #868 incorrectly set pr_number=868 (the OCC PR itself).
All three receipts now carry commit_sha=d61beb07 (this OCC PR's commit), enabling validator_occ_merge_eligibility to bind via SHA match when receipt.pr_number (1552) != OCC PR number.
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
jonahgabriel
enabled auto-merge (squash)
May 9, 2026 16:12
jonahgabriel
added a commit
that referenced
this pull request
Aug 12, 2026
All 8 pre-existing dod_evidence items on contracts/OMN-14362.yaml were INSIDE_OWN_DIFF (self-referential receipt-file greps) or NOT_EXECUTED (bare `gh pr view` existence checks) under the OMN-15309 admissibility predicate, so Contract Compliance Check reported 0/8 PASS and BLOCKed both this PR (#6380) and the wired PR omninode_infra#874 with "no hosted-and-local effective check exists". Append two new admissible (EXECUTED + FALSIFIABLE + OUTSIDE-ITS-OWN-DIFF) dod_evidence items pinned to omninode_infra#874's live head cfeb4867fd528db01496d851c219e8c88a1bd12a, following the OMN-15871 gh-api-content pattern: - dod-OmniNode-ai-omninode_infra-pr-874-diff-scope: `gh api repos/OmniNode-ai/omninode_infra/pulls/874/files` (product diff scope) - dod-OmniNode-ai-omninode_infra-pr-874-ci: `gh api .../contents/ k8s/onex-dev/api/deployment.yaml?ref=<head> | base64 -d | grep -c TENANT_BOOTSTRAP_ADMIN_SECRET` (content-bound proof the secretKeyRef wiring exists at the pinned head; falsifiable, absent at merge-base) Matching PASS receipts under drift/dod_receipts/OMN-14362/. Append-only: no existing dod_evidence entry modified or removed (verified via git diff against origin branch). Verified locally with scripts/ci/run_contract_compliance_check.py against both PR #6380 and PR #874: 0 BLOCK -> 2/10 PASS, 8 WARN, 0 BLOCK for both. Ticket: OMN-14362
jonahgabriel
added a commit
that referenced
this pull request
Aug 12, 2026
…ppend The receipt-hardening gate (OMN-13060) flagged 9 receipt files under drift/dod_receipts/OMN-14362/ still pinned to the pre-repair contract hash (4ac0c13e...) after the prior commit appended 2 new dod_evidence items and changed contracts/OMN-14362.yaml's sha256 to b5ca0fee.... All 9 files were introduced earlier in this same open PR (never merged to dev), so re-pinning them is not an append-only violation of merged content -- it corrects an in-flight PR's own not-yet-landed receipts. Verified: scripts/validation/check_receipt_hardening.py exits 0 on the full changed-file set; scripts/ci/run_contract_compliance_check.py still reports 0 BLOCK / 2 PASS for both PR #6380 and PR #874. Ticket: OMN-14362
jonahgabriel
added a commit
that referenced
this pull request
Aug 12, 2026
…#6380) * evidence: OCC companion pass 1 for OmniNode-ai/omninode_infra#874 * evidence: OCC companion self-bind for #6380 * fix(OMN-14362): repair OCC#6380 append-only INADMISSIBLE contract check All 8 pre-existing dod_evidence items on contracts/OMN-14362.yaml were INSIDE_OWN_DIFF (self-referential receipt-file greps) or NOT_EXECUTED (bare `gh pr view` existence checks) under the OMN-15309 admissibility predicate, so Contract Compliance Check reported 0/8 PASS and BLOCKed both this PR (#6380) and the wired PR omninode_infra#874 with "no hosted-and-local effective check exists". Append two new admissible (EXECUTED + FALSIFIABLE + OUTSIDE-ITS-OWN-DIFF) dod_evidence items pinned to omninode_infra#874's live head cfeb4867fd528db01496d851c219e8c88a1bd12a, following the OMN-15871 gh-api-content pattern: - dod-OmniNode-ai-omninode_infra-pr-874-diff-scope: `gh api repos/OmniNode-ai/omninode_infra/pulls/874/files` (product diff scope) - dod-OmniNode-ai-omninode_infra-pr-874-ci: `gh api .../contents/ k8s/onex-dev/api/deployment.yaml?ref=<head> | base64 -d | grep -c TENANT_BOOTSTRAP_ADMIN_SECRET` (content-bound proof the secretKeyRef wiring exists at the pinned head; falsifiable, absent at merge-base) Matching PASS receipts under drift/dod_receipts/OMN-14362/. Append-only: no existing dod_evidence entry modified or removed (verified via git diff against origin branch). Verified locally with scripts/ci/run_contract_compliance_check.py against both PR #6380 and PR #874: 0 BLOCK -> 2/10 PASS, 8 WARN, 0 BLOCK for both. Ticket: OMN-14362 * fix(OMN-14362): re-pin stale receipt contract_sha256 after evidence append The receipt-hardening gate (OMN-13060) flagged 9 receipt files under drift/dod_receipts/OMN-14362/ still pinned to the pre-repair contract hash (4ac0c13e...) after the prior commit appended 2 new dod_evidence items and changed contracts/OMN-14362.yaml's sha256 to b5ca0fee.... All 9 files were introduced earlier in this same open PR (never merged to dev), so re-pinning them is not an append-only violation of merged content -- it corrects an in-flight PR's own not-yet-landed receipts. Verified: scripts/validation/check_receipt_hardening.py exits 0 on the full changed-file set; scripts/ci/run_contract_compliance_check.py still reports 0 BLOCK / 2 PASS for both PR #6380 and PR #874. Ticket: OMN-14362 --------- Co-authored-by: node-occ-companion-effect <occ-companion-effect@omninode.ai> Co-authored-by: Jonah Gray <jonah@omninode.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Corrects the DoD receipts from the previously-merged OCC PR #868 for OMN-10734.
Problem with PR #868: Receipts had
commit_sha: 33c0570852...(omniclaude commit, not OCC), which means OCC's ownverify/verifygate could not bind them via SHA (since omniclaude SHAs are not in OCC PR commits), andpr_numberwas 868 (OCC PR) instead of 1552 (omniclaude PR).This PR fixes:
pr_number: 1552— binds to omniclaude PR contracts(OMN-11913): add deploy evidence for omnimarket 824 #1552 for cross-repo gate resolutioncommit_sha: d61beb07f9d6aba0a1bbdd1f21bca0341213c064— an OCC commit in this PR's history, enabling OCC's own gate to bind viareceipt.commit_sha in OCC_PR_commit_SHAsEvidence-Ticket: OMN-10734
Evidence-Source: OCC#875
Receipts
dod-pr-1552-ci-green: omniclaude PR contracts(OMN-11913): add deploy evidence for omnimarket 824 #1552 CI all-green (tests, quality gate, arch-no-env-fallbacks)dod-validator-pass:validate_no_env_fallbacks.pyclean after removing localhost defaults fromcontext_config.pydod-occ-pr: This OCC PR open with contract + receipts bound to omniclaude PR contracts(OMN-11913): add deploy evidence for omnimarket 824 #1552